Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

test: fix test failures due to $route not being stringified #3095

Merged
merged 2 commits into from
Sep 12, 2024

Conversation

BobbieGoede
Copy link
Collaborator

@BobbieGoede BobbieGoede commented Sep 12, 2024

πŸ”— Linked issue

❓ Type of change

  • πŸ“– Documentation (updates to the documentation, readme or JSdoc annotations)
  • 🐞 Bug fix (a non-breaking change that fixes an issue)
  • πŸ‘Œ Enhancement (improving an existing functionality like performance)
  • ✨ New feature (a non-breaking change that adds functionality)
  • 🧹 Chore (updates to the build process or auxiliary tools and libraries)
  • ⚠️ Breaking change (fix or feature that would cause existing functionality to change)

πŸ“š Description

This targets the failing tests in Nuxt's ecosystem-ci, changes in Nuxt prevent the stringifying of $route and prevents hydration from updating/rendering the stringified route. (nuxt/nuxt#28841)

We should consider changing these tests to check the localeRoute results keys instead of comparing the entire object, or figure out how to test its results in unit tests.

πŸ“ Checklist

  • I have linked an issue or discussion.
  • I have added tests (if possible).
  • I have updated the documentation accordingly.

@BobbieGoede BobbieGoede self-assigned this Sep 12, 2024
@BobbieGoede BobbieGoede marked this pull request as ready for review September 12, 2024 11:00
@BobbieGoede BobbieGoede changed the title test: fix route tests test: fix $route stringification failing in tests Sep 12, 2024
@BobbieGoede BobbieGoede changed the title test: fix $route stringification failing in tests test: fix test failures due to $route not being stringified Sep 12, 2024
@BobbieGoede BobbieGoede merged commit 87d773b into nuxt-modules:main Sep 12, 2024
7 checks passed
@BobbieGoede BobbieGoede deleted the test/fix-route-tests branch September 12, 2024 11:03
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant