Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: cookie storage #221

Merged
merged 34 commits into from
Sep 13, 2024
Merged

feat: cookie storage #221

merged 34 commits into from
Sep 13, 2024

Conversation

manniL
Copy link
Contributor

@manniL manniL commented Nov 25, 2023

PR based on #188 with changes mentioned there.

Hossein Mirazimi and others added 26 commits March 17, 2023 19:18
Co-authored-by: renovate[bot] <29139614+renovate[bot]@users.noreply.github.com>
Co-authored-by: renovate[bot] <29139614+renovate[bot]@users.noreply.github.com>
)

Co-authored-by: renovate[bot] <29139614+renovate[bot]@users.noreply.github.com>
Co-authored-by: renovate[bot] <29139614+renovate[bot]@users.noreply.github.com>
Co-authored-by: renovate[bot] <29139614+renovate[bot]@users.noreply.github.com>
Copy link

netlify bot commented Nov 25, 2023

Deploy Preview for nuxt-color-mode canceled.

Name Link
🔨 Latest commit 427e5bd
🔍 Latest deploy log https://app.netlify.com/sites/nuxt-color-mode/deploys/656279bcfd066e0009a84890

@manniL manniL mentioned this pull request Nov 25, 2023
@atinux
Copy link
Contributor

atinux commented Nov 29, 2023

Thanks! Happy to check the CI failing?

@manniL
Copy link
Contributor Author

manniL commented Nov 29, 2023

Whoops, yes sure.

@tasiotas
Copy link

Hi, could you try to run it again to see if CI will pass.
Thank you

@juls0730 juls0730 mentioned this pull request Apr 24, 2024
@itpropro
Copy link

Any update on this PR?

@sharifzadesina
Copy link

It seems older versions of color mode already had cookie storage for SSR support. but newer versions for Nuxt 3, don't.
It will be a good move to support cookie storage again.

@atinux atinux merged commit c4df5d9 into nuxt-modules:main Sep 13, 2024
1 check passed
@manniL manniL deleted the cookie-storage branch September 15, 2024 08:49
@manniL
Copy link
Contributor Author

manniL commented Sep 15, 2024

@atinux Thanks for finishing this up 🔥

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

8 participants