Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

fix: make syncing dark mode across tabs and windows work again (#119) #120

Open
wants to merge 2 commits into
base: main
Choose a base branch
from
Open

fix: make syncing dark mode across tabs and windows work again (#119) #120

wants to merge 2 commits into from

Commits on Feb 9, 2022

  1. chore(lint): disable eslint rule "nuxt/no-globals-in-created" in clie… 

    …nt plugin

The client plugin is intended to be run in the browser only.  Since the
client plugin already assumes that "window" exists and references it
directly here and there, there's no use in forbidding "window"
references in beforeCreate/created hooks.
    @jinohkang-theori
    jinohkang-theori committed Feb 9, 2022
    Configuration menu
    Copy the full SHA
    eecc1bc View commit details
    Browse the repository at this point in the history

  2. Revert "fix: don't use window in created (nuxt-modules#59)" 

    This reverts commit 9b47c6e.

Put the storage watcher back to the created() hook.  This fixes the
regression that breaks cross-window dark mode synchronization.

This bug is caused by the mounted() hook never being invoked, since the
$colorMode component is not actually mounted anywhere.  Also note that
there's nothing wrong in referencing "window" in the created() hook;
this is a client plugin, and other code in the same file references
"window" already.
    @jinohkang-theori
    jinohkang-theori committed Feb 9, 2022
    Configuration menu
    Copy the full SHA
    c6a8e61 View commit details
    Browse the repository at this point in the history