Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Warn using consola instead of throwing Error #1

Merged
merged 7 commits into from
Oct 4, 2018

Conversation

aldarund
Copy link
Collaborator

@aldarund aldarund commented Oct 3, 2018

No description provided.

@aldarund aldarund requested review from TheAlexLichter and pi0 October 3, 2018 13:53
@TheAlexLichter
Copy link
Member

TheAlexLichter commented Oct 3, 2018

We might want to consider stringify Symbols (otherwise apollo breaks as described here)

@aldarund
Copy link
Collaborator Author

aldarund commented Oct 3, 2018

@manniL do u know a good way to serialize them? I dont know :)
And with this changes it will print warning instead of breaking. They wasnt serializing before too.

@TheAlexLichter
Copy link
Member

The change itself is fine 👏

Not sure. We should consult the serialize-javascript source code for this I think 🤔

@aldarund
Copy link
Collaborator Author

aldarund commented Oct 3, 2018

seializa-javascript dont do anything with symbols
https://runkit.com/5baa3cac92a46f00121e2985/5bb4e0d021ea590012334d7d

@TheAlexLichter
Copy link
Member

Ah, well then we should just preserve them as they do I guess 🤷‍♂️

@aldarund aldarund requested a review from clarkdo October 3, 2018 18:53
Copy link

@clarkdo clarkdo left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@victor-perez
Copy link

This will not fix Rich-Harris#15

@aldarund
Copy link
Collaborator Author

aldarund commented Oct 4, 2018

I dont think vuex is supposed to be work with immutable.js in first place.
https://forum.vuejs.org/t/immutable-js-with-vue/6366/8
vuejs/vuex#802 (comment)

@victor-perez
Copy link

@aldarund before the switch to devalue there was no problem with using immutable this update is breaking this. And you can use immutable easily with vuex even with Nuxt using https://www.npmjs.com/package/vuex-immutable-replace-state
But that is not my point, devalue state that is like JSON.stringify but it doesn't handle Object that have a toJSON method.

@aldarund
Copy link
Collaborator Author

aldarund commented Oct 4, 2018

I added support for object with toJSON method

@aldarund aldarund merged commit c3943a4 into nuxt-contrib:master Oct 4, 2018
@pi0 pi0 mentioned this pull request Feb 1, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

5 participants