Skip to content
This repository has been archived by the owner on Dec 5, 2024. It is now read-only.

chore: dep updates and minor internal type fixes #748

Merged
merged 11 commits into from
Mar 31, 2023
Merged

chore: dep updates and minor internal type fixes #748

merged 11 commits into from
Mar 31, 2023

Conversation

rchl
Copy link
Member

@rchl rchl commented Mar 30, 2023

Nothing important really. Just felt like enabling type checking for *.vue and *.js files to catch some extra issues.

@rchl rchl requested a review from danielroe March 30, 2023 20:22
@rchl
Copy link
Member Author

rchl commented Mar 30, 2023

Windows and Ubuntu seem to timeout on running test:e2e-generated. Not quite sure what's the reason. Even tried locally on a Windows virtual machine and it works fine there.

Run yarn test:e2e-generated
yarn run v1.22.19
$ cross-env GENERATE=true PORT=5000 start-server-and-test fixture:generate 5000 "testcafe -q firefox:headless test/e2e"
1: starting server using command "npm run fixture:generate"
and when url "[ 'http://localhost:5000' ]" is responding with HTTP status code NaN
running tests using command "testcafe -q firefox:headless test/e2e"


> @nuxtjs/[email protected] fixture:generate
> yarn fixture:generate:export && yarn http-server -s -p 5000 test/fixture/dist

$ yarn clean:fixture && cross-env GENERATE=true PORT=6000 CMD=generate yarn nuxt-run
$ rimraf test/fixture/dist/ test/fixture/.nuxt
$ cross-env-shell "yarn nuxt $CMD test/fixture"
$ /home/runner/work/composition-api/composition-api/node_modules/.bin/nuxt generate test/fixture
[log] Testing built module
[log] Testing built module
$ /home/runner/work/composition-api/composition-api/node_modules/.bin/http-server -s -p 5000 test/fixture/dist
Error: Timed out waiting for: http://localhost:5000
    at /home/runner/work/composition-api/composition-api/node_modules/wait-on/lib/wait-on.js:132:31
    at doInnerSub (/home/runner/work/composition-api/composition-api/node_modules/wait-on/node_modules/rxjs/dist/cjs/internal/operators/mergeInternals.js:22:31)
    at outerNext (/home/runner/work/composition-api/composition-api/node_modules/wait-on/node_modules/rxjs/dist/cjs/internal/operators/mergeInternals.js:17:70)
    at OperatorSubscriber._this._next (/home/runner/work/composition-api/composition-api/node_modules/wait-on/node_modules/rxjs/dist/cjs/internal/operators/OperatorSubscriber.js:33:21)
    at Subscriber.next (/home/runner/work/composition-api/composition-api/node_modules/wait-on/node_modules/rxjs/dist/cjs/internal/Subscriber.js:51:18)
    at AsyncAction.work (/home/runner/work/composition-api/composition-api/node_modules/wait-on/node_modules/rxjs/dist/cjs/internal/observable/timer.js:28:28)
    at AsyncAction._execute (/home/runner/work/composition-api/composition-api/node_modules/wait-on/node_modules/rxjs/dist/cjs/internal/scheduler/AsyncAction.js:79:18)
    at AsyncAction.execute (/home/runner/work/composition-api/composition-api/node_modules/wait-on/node_modules/rxjs/dist/cjs/internal/scheduler/AsyncAction.js:67:26)
    at AsyncScheduler.flush (/home/runner/work/composition-api/composition-api/node_modules/wait-on/node_modules/rxjs/dist/cjs/internal/scheduler/AsyncScheduler.js:38:33)
    at listOnTimeout (node:internal/timers:569:17)
    at process.processTimers (node:internal/timers:512:7)
error Command failed with exit code 1.
info Visit https://yarnpkg.com/en/docs/cli/run for documentation about this command.
Error: Process completed with exit code 1.

@danielroe
Copy link
Member

Merged #740 to address CI failure - hopefully things will work once rebased/merged.

@rchl
Copy link
Member Author

rchl commented Mar 31, 2023

Switched to Node 16? Should have thought of that :)

rchl added 2 commits March 31, 2023 13:40
* origin/main:
  chore: upgrade dependencies (#740
  docs: remove mentions of Vue 3
@rchl rchl changed the title chore: minor internal type fixes chore: dep updates and minor internal type fixes Mar 31, 2023
@rchl
Copy link
Member Author

rchl commented Mar 31, 2023

Looking good now.

@rchl rchl merged commit e894de2 into main Mar 31, 2023
@rchl rchl deleted the fix/types branch March 31, 2023 17:26
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants