Fix HideToTray checkbox not being synced properly with database at boot #691
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
guihkx
approved these changes
Sep 1, 2024
|
That was an annoying issue I forgot to document (or maybe I thought it's a bug in Qt). Thanks for that @zjeffer! |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes a bug where at startup, the 'checked' state of the hideToTray option would always be false. Checking the box would then also disable the tray icon, while unchecking the box would enable it.
This happened because
m_hideToTraywould only be loaded from the database in therestoreState(), which is called after thehideToTrayAction->setChecked(m_hideToTray);insetupGlobalSettingsMenu(). The initial state would therefore always be false, even if the user hastruein their database.