added on_ready_change event handler and tests #19
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Contributor
f34rdotcom
commented
Apr 5, 2018
•
f34rdotcom
commented
- This addition allows notification on the panel ready state change. Useful to know if you can arm the alarm or not or arming will just fail and the remote end will not know why.
- Fixed some of the issue with events getting different panel states upon the same message from the panel.
- Turned off processing of LRR messages into events by default as it was causing fire to bounce.
- Disable timeouts on fire. Fire is fire till it is turned off. Maybe the LRR processing could be ok with this change but will leave off for now. Eventually it would also be nice to add AUI event processing so we get the fastest update possible since standard messages are slower.
… LOW messages to avoid Ademco quirk. Removed processing of LRR messages as default behavior to avoid over processing of events from section #1 and LRR.
…g one message to be missing status bits of the other. Refactor to a new routine to avoid breaking anyone. New routine processes all state logic first for both ready and arm bits then calls event functions last.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.