Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

handling version in read context #606

Merged
merged 2 commits into from
Jun 14, 2023
Merged

handling version in read context #606

Changes from all commits
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
8d286f1
handling version in read context
Abhishekism9450 Jun 12, 2023
097e874
func to handle version in k8s
Abhishekism9450 Jun 13, 2023
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
30 changes: 24 additions & 6 deletions nutanix/resource_nutanix_karbon_cluster.go
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -569,15 +569,16 @@ func resourceNutanixKarbonClusterRead(ctx context.Context, d *schema.ResourceDat
}

// Must use know version because GA API reports different version
var versionSet string
if version, ok := d.GetOk("version"); ok {
versionSet = version.(string)
} else {
versionSet = utils.StringValue(resp.Version)
karbonVersion, er := conn.Meta.GetSemanticVersion()
if er != nil {
return diag.Errorf("error getting karbon version")
}
if err = d.Set("version", versionSet); err != nil {

karbonVersionSet := checkKarbonVersion(d, karbonVersion, resp)
if err = d.Set("version", karbonVersionSet); err != nil {
return diag.Errorf("error setting version for Karbon Cluster %s: %s", d.Id(), err)
}

if err = d.Set("kubeapi_server_ipv4_address", utils.StringValue(resp.KubeAPIServerIPv4Address)); err != nil {
return diag.Errorf("error setting kubeapi_server_ipv4_address for Karbon Cluster %s: %s", d.Id(), err)
}
Expand Down Expand Up @@ -1254,3 +1255,20 @@ func calculateCPURequirement(karbonVersion *karbon.MetaSemanticVersionResponse,
log.Printf("[DEBUG] version was 2.2.2 or higher. NOT applying CPU workaround")
return amountOfCPU, nil
}

func checkKarbonVersion(d *schema.ResourceData, karbonVersion *karbon.MetaSemanticVersionResponse, karbonResp *karbon.ClusterIntentResponse) string {
const baseMajorVersion int64 = 2
const baseMinorVersion int64 = 2
const baseRevVersion int64 = 3
var versionSet string
if karbonVersion.MajorVersion <= baseMajorVersion && karbonVersion.MinorVersion <= baseMinorVersion && karbonVersion.RevisionVersion < baseRevVersion {
if version, ok := d.GetOk("version"); ok {
versionSet = version.(string)
} else {
versionSet = utils.StringValue(karbonResp.Version)
}
} else {
versionSet = *karbonResp.Version
}
return versionSet
}