first version of v4 client integration in prism-go-client #133
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
thunderboltsid
previously approved these changes
Aug 31, 2023
|
Please add a Changelog entry too |
yannickstruyf3
dismissed stale reviews from thunderboltsid and tuxtof
via
4c6c2e1
yannickstruyf3
force-pushed
the
feat/v4-client-initial
branch
from
ccba38f to
4c6c2e1
Compare
|
Added Changelog entry |
tuxtof
approved these changes
Sep 9, 2023
tuxtof
force-pushed
the
feat/v4-client-initial
branch
from
4c6c2e1 to
6468b32
Compare
Codecov Report
❗ Your organization needs to install the Codecov GitHub app to enable full functionality. @@ Coverage Diff @@
## main #133 +/- ##
==========================================
+ Coverage 52.96% 54.30% +1.34%
==========================================
Files 19 20 +1
Lines 1722 1799 +77
==========================================
+ Hits 912 977 +65
- Misses 810 822 +12
📣 We’re building smart automated test selection to slash your CI/CD build times. Learn more |
thunderboltsid
approved these changes
Sep 15, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Adds a new v4Client that holds v4 api instances.