refactor: kube-vip commands #699
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
dkoshkin
commented
Jun 7, 2024
...andlers/generic/mutation/controlplanevirtualip/providers/templates/configure-for-kube-vip.sh
Outdated
Show resolved
Hide resolved
![github-actions[bot]](https://avatars.githubusercontent.com/in/15368?s=60&v=4){kind=small}
pkg/handlers/generic/mutation/controlplanevirtualip/providers/kubevip.go
Show resolved
Hide resolved
pkg/handlers/generic/mutation/controlplanevirtualip/providers/kubevip.go
Outdated
Show resolved
Hide resolved
pkg/handlers/generic/mutation/controlplanevirtualip/providers/kubevip_test.go
Outdated
Show resolved
Hide resolved
pkg/handlers/generic/mutation/controlplanevirtualip/providers/kubevip.go
Outdated
Show resolved
Hide resolved
pkg/handlers/generic/mutation/controlplanevirtualip/providers/kubevip.go
Outdated
Show resolved
Hide resolved
pkg/handlers/generic/mutation/controlplanevirtualip/providers/kubevip.go
Show resolved
Hide resolved
pkg/handlers/generic/mutation/controlplanevirtualip/providers/kubevip.go
Outdated
Show resolved
Hide resolved
dkoshkin
force-pushed
the
dkoshkin/refactor-kube-vip-commands
branch
2 times, most recently
from
0d5c982 to
ffa0cfc
Compare
jimmidyson
reviewed
Jun 11, 2024
...andlers/generic/mutation/controlplanevirtualip/providers/templates/configure-for-kube-vip.sh
Outdated
Show resolved
Hide resolved
jimmidyson
approved these changes
Jun 11, 2024
faiq
reviewed
Jun 11, 2024
charts/cluster-api-runtime-extensions-nutanix/defaultclusterclasses/nutanix-cluster-class.yaml
Show resolved
Hide resolved
dkoshkin
force-pushed
the
dkoshkin/refactor-kube-vip-commands
branch
from
ffa0cfc to
c49ea92
Compare
This makes it more consistent with the other preKubeadmCommands
Workaround for kube-vip/kube-vip#692. Moving it to the kube-vip handler so that it can be applied to other providers.
dkoshkin
force-pushed
the
dkoshkin/refactor-kube-vip-commands
branch
from
c49ea92 to
395a503
Compare
dkoshkin
force-pushed
the
dkoshkin/refactor-kube-vip-commands
branch
from
395a503 to
f2baa93
Compare
jimmidyson
approved these changes
Jun 12, 2024
Merged
faiq
pushed a commit
that referenced
this pull request
Jun 24, 2024
🤖 I have created a release *beep* *boop* --- ## 0.10.0 (2024-06-24) <!-- Release notes generated using configuration in .github/release.yaml at main --> ## What's Changed ### Exciting New Features 🎉 * feat: Upgrade to Cilium v1.15.5 by @jimmidyson in #689 * feat: Upgrade to Calico v3.28.0 by @jimmidyson in #688 * feat: bumps caaph to v0.2.3 by @faiq in #691 * feat: Add local-path-provisioner CSI by @jimmidyson in #693 * feat: cluster-api v1.7.3 by @jimmidyson in #714 * feat: bumps caaph to 0.2.4 by @faiq in #718 * feat: Controller that copies ClusterClasses to namespaces by @dlipovetsky in #715 * feat: adds a mindthegap container and deployment by @faiq in #637 * feat: implements BeforeClusterUpgrade hook by @faiq in #682 ### Fixes 🔧 * fix: use external Nutanix API types directly by @dkoshkin in #698 * fix: Post-process clusterconfig CRDs for supported CSI providers by @jimmidyson in #695 * fix: nutanix credentials Secrets owner refs by @dkoshkin in #711 * fix: credential provider response secret ownership by @dkoshkin in #709 * fix: static credentials Secret generation by @dkoshkin in #717 * fix: set ownerReference on imageRegistry and globalMirror Secrets by @dkoshkin in #720 * fix: Allow Nutanix CSI snapshot controller & webhook to run on CP nodes by @dlipovetsky in #723 * refactor: Use maps for CSI providers and storage classes by @jimmidyson in #696 * fix: CredentialProviderConfig matchImages to support registries with port by @dkoshkin in #724 * fix: Allow Node Feature Discovery garbage collector to run on control-plane nodes by @dlipovetsky in #722 * fix: RBAC role for namespace-sync controller to watch,list namespaces by @dkoshkin in #738 * fix: image registries not handling CA certificates by @dkoshkin in #729 * fix: adds a docker buildx step before release-snapshot by @faiq in #741 ### Other Changes * docs: Add released version to helm and clusterctl install by @jimmidyson in #683 * revert: Temporary lint config fix until next golangci-lint release (#629) by @jimmidyson in #686 * refactor: Delete unused code by @jimmidyson in #687 * refactor: Reduce log verbosity for skipped handlers by @jimmidyson in #692 * build: update Go to 1.22.4 by @dkoshkin in #700 * build(deps): Upgrade CAPX version to v1.4.0 by @thunderboltsid in #707 * build: Move CSI supported provider logic to script by @jimmidyson in #703 * build: Add testifylint linter by @jimmidyson in #706 * build: Update all tools by @jimmidyson in #704 * refactor: rename credential provider response secret by @dkoshkin in #710 * refactor: Simplify code by using slices.Clone by @jimmidyson in #712 * refactor: consistently use the same SetOwnerReference function by @dkoshkin in #713 * refactor: kube-vip commands by @dkoshkin in #699 * build: Fix an incorrect make variable passed to goreleaser by @dlipovetsky in #716 * build: Add 'chart-docs' make target by @dlipovetsky in #727 * build: Make CAREN mindthegap reg multiarch by @jimmidyson in #730 * Add helm values schema plugin by @dlipovetsky in #728 * test(e2e): Use mesosphere fork with CRSBinding fix by @jimmidyson in #736 ## New Contributors * @thunderboltsid made their first contribution in #707 **Full Changelog**: v0.9.0...v0.10.0 --- This PR was generated with [Release Please](https://github.com/googleapis/release-please). See [documentation](https://github.com/googleapis/release-please#release-please). Co-authored-by: github-actions[bot] <41898282+github-actions[bot]@users.noreply.github.com>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What problem does this PR solve?:
This PR refactors the kube-vip handler to:
echo "127.0.0.1 kubernetes" >>/etc/hostsout of the template and into the handler since this command is not unique to Nutanix and would be needed for other infra providers using kube-vip.Which issue(s) this PR fixes:
Fixes #
How Has This Been Tested?:
Special notes for your reviewer: