Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

refactor: Split flag and config init into testable steps, and add tests #497

Open
wants to merge 1 commit into
base: main
Choose a base branch
from

Conversation

dlipovetsky
Copy link
Contributor

What this PR does / why we need it:
Splits the flag and config initialization into testable steps, and adds tests of each.

The previous tests did not help us catch the regression fixed in #494. The new tests do.

Which issue(s) this PR fixes (optional, in fixes #<issue number>(, fixes #<issue_number>, ...) format, will close the issue(s) when PR gets merged):
Fixes #

How Has This Been Tested?:

Please describe the tests that you ran to verify your changes. Provide instructions so we can reproduce. Please also list any relevant details for your test configuration and test output

Special notes for your reviewer:

Please confirm that if this PR changes any image versions, then that's the sole change this PR makes.

Release note:


@dlipovetsky dlipovetsky force-pushed the jira/NCN-105235 branch 2 times, most recently from 06379f2 to 6e521cd Compare January 18, 2025 01:53
Copy link

codecov bot commented Jan 18, 2025

Codecov Report

Attention: Patch coverage is 78.87324% with 15 lines in your changes missing coverage. Please review.

Project coverage is 34.40%. Comparing base (f1bbf93) to head (3ed188f).

Files with missing lines Patch % Lines
main.go 78.87% 13 Missing and 2 partials ⚠️
Additional details and impacted files
@@            Coverage Diff             @@
##             main     #497      +/-   ##
==========================================
+ Coverage   33.45%   34.40%   +0.95%     
==========================================
  Files          17       17              
  Lines        2236     2267      +31     
==========================================
+ Hits          748      780      +32     
+ Misses       1468     1467       -1     
  Partials       20       20              

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant