Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

refactor: Make available complete image info, instead of UUID only #489

Open
wants to merge 2 commits into
base: main
Choose a base branch
from

Conversation

dlipovetsky
Copy link
Contributor

What this PR does / why we need it:
We plan to make decisions based on the complete image info.

Which issue(s) this PR fixes (optional, in fixes #<issue number>(, fixes #<issue_number>, ...) format, will close the issue(s) when PR gets merged):
Fixes #

How Has This Been Tested?:

Please describe the tests that you ran to verify your changes. Provide instructions so we can reproduce. Please also list any relevant details for your test configuration and test output

Special notes for your reviewer:

Please confirm that if this PR changes any image versions, then that's the sole change this PR makes.

Release note:


@thunderboltsid
Copy link
Contributor

thunderboltsid commented Dec 3, 2024

trying to fix the failing tests in #490 and #491

We plan to make decisions based on some of the information.
@dlipovetsky dlipovetsky force-pushed the jira/NCN-101014-refactor-get-image branch from 84f076c to 236044f Compare December 3, 2024 18:25
Copy link

codecov bot commented Dec 3, 2024

Codecov Report

Attention: Patch coverage is 50.00000% with 18 lines in your changes missing coverage. Please review.

Project coverage is 34.70%. Comparing base (fec1de5) to head (1434308).

Files with missing lines Patch % Lines
controllers/nutanixmachine_controller.go 0.00% 10 Missing ⚠️
api/v1beta1/nutanix_types.go 0.00% 8 Missing ⚠️
Additional details and impacted files
@@            Coverage Diff             @@
##             main     #489      +/-   ##
==========================================
+ Coverage   33.46%   34.70%   +1.23%     
==========================================
  Files          17       18       +1     
  Lines        2235     2239       +4     
==========================================
+ Hits          748      777      +29     
+ Misses       1467     1442      -25     
  Partials       20       20              

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

…only

Refactor further; add unit tests with mocks
@dlipovetsky
Copy link
Contributor Author

I made substantial changes to GetImageByNameOrUUID, and I've created new unit tests for this--there were none before. I made incidental changes to getSystemDisk or getBootstrapDisk, and I'm not convinced I should add unit tests for these in this PR.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants