Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update ci-e2e.sh to quote LABEL_FILTERS value #429

Merged
merged 1 commit into from
May 2, 2024

Conversation

thunderboltsid
Copy link
Contributor

This is to ensure the full value of LABEL_FILTERS gets propagated.

Copy link

codecov bot commented May 2, 2024

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 9.28%. Comparing base (6cb4938) to head (9064cee).

Additional details and impacted files
@@             Coverage Diff              @@
##           release-v1.2    #429   +/-   ##
============================================
  Coverage          9.28%   9.28%           
============================================
  Files                10      10           
  Lines              1335    1335           
============================================
  Hits                124     124           
  Misses             1211    1211           

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@thunderboltsid thunderboltsid force-pushed the issue/e2e-label branch 2 times, most recently from e084975 to d17b633 Compare May 2, 2024 16:47
@thunderboltsid
Copy link
Contributor Author

/test e2e-nutanix-features

This is to ensure the full value of LABEL_FILTERS gets propagated.
Copy link

github-actions bot commented May 2, 2024

✅ None of your dependencies violate policy!

Copy link
Contributor

@adiantum adiantum left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

/lgtm
/approve
/wouf

@thunderboltsid
Copy link
Contributor Author

This works!

...
NUTANIX_LOG_LEVEL=debug /home/prow/go/src/github.com/nutanix-cloud-native/cluster-api-provider-nutanix/hack/tools/bin/ginkgo-v2.1.4 -v \
	--trace \
	--progress \
	--tags=e2e \
	--label-filter="!only-for-validation && !cluster-upgrade-conformance && !conformance" \
	--skip=""clusterctl-Upgrade"" \
	--focus="""" \
	--nodes=1 \
	--no-color=false \
	--output-dir="/logs/artifacts" \
	--junit-report="junit.e2e_suite.1.xml" \
	--timeout="24h" \
	--always-emit-ginkgo-writer \
	 ./test/e2e -- \
	-e2e.artifacts-folder="/logs/artifacts" \
	-e2e.config="/home/prow/go/src/github.com/nutanix-cloud-native/cluster-api-provider-nutanix/test/e2e/config/nutanix.yaml" \
	-e2e.skip-resource-cleanup=false \
	-e2e.use-existing-cluster=false

@thunderboltsid thunderboltsid merged commit b74ab58 into release-v1.2 May 2, 2024
7 of 9 checks passed
@thunderboltsid thunderboltsid deleted the issue/e2e-label branch May 2, 2024 17:56
@nutanix-cn-prow-bot
Copy link

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: adiantum, deepakm-ntnx, thunderboltsid

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:
  • OWNERS [adiantum,deepakm-ntnx,thunderboltsid]

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants