-
Notifications
You must be signed in to change notification settings - Fork 22
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
use latest version of capx in template-tests #410
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
/lgtm
/approve
working on following issue
|
9075419
to
fce336c
Compare
[APPROVALNOTIFIER] This PR is APPROVED This pull-request has been approved by: deepakm-ntnx, thunderboltsid The full list of commands accepted by this bot can be found here. The pull request process is described here
Needs approval from an approver in each of these files:
Approvers can indicate their approval by writing |
fce336c
to
394cddc
Compare
37cc02e
to
0104c28
Compare
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## main #410 +/- ##
=======================================
Coverage 25.07% 25.07%
=======================================
Files 19 19
Lines 1332 1332
=======================================
Hits 334 334
Misses 998 998 ☔ View full report in Codecov by Sentry. |
Seems like this problem is not showing up here again |
/retest |
I'm confused by the tide check message: |
We have explicitly disabled everything but squash and merge to avoid polluting history with unclean merges and enable easy revert of entire PRs, and I'm guessing it's just complaining because the check is expecting a non-squashed merge. We need to revisit the configuration of that tide check. cc @adiantum |
@deepakm-ntnx: The following tests failed, say
Full PR test history. Your PR dashboard. Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. I understand the commands that are listed here. |
0104c28
to
1715083
Compare
1715083
to
ee29a0a
Compare
What this PR does / why we need it:
Which issue(s) this PR fixes (optional, in
fixes #<issue number>(, fixes #<issue_number>, ...)
format, will close the issue(s) when PR gets merged):Fixes #
How Has This Been Tested?:
Please describe the tests that you ran to verify your changes. Provide instructions so we can reproduce. Please also list any relevant details for your test configuration and test output
Special notes for your reviewer:
Please confirm that if this PR changes any image versions, then that's the sole change this PR makes.
Release note: