Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

use latest version of capx in template-tests #410

Merged
merged 2 commits into from
Apr 29, 2024
Merged

Conversation

deepakm-ntnx
Copy link
Contributor

What this PR does / why we need it:

Which issue(s) this PR fixes (optional, in fixes #<issue number>(, fixes #<issue_number>, ...) format, will close the issue(s) when PR gets merged):
Fixes #

How Has This Been Tested?:

Please describe the tests that you ran to verify your changes. Provide instructions so we can reproduce. Please also list any relevant details for your test configuration and test output

Special notes for your reviewer:

Please confirm that if this PR changes any image versions, then that's the sole change this PR makes.

Release note:


go.mod Outdated Show resolved Hide resolved
@thunderboltsid thunderboltsid changed the title upgraded golang to 1.22.2 Switch go.mod golang version to 1.21 Apr 11, 2024
thunderboltsid
thunderboltsid previously approved these changes Apr 11, 2024
Copy link
Contributor

@thunderboltsid thunderboltsid left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

/lgtm
/approve

@deepakm-ntnx
Copy link
Contributor Author

working on following issue


Cluster Class Template Patches Test Suite patches for failure domains Control Plane NutanixMachineTemplate should not have the cluster and subnets set
/Users/deepak.muley/go/src/github.com/nutanix-cloud-native/cluster-api-provider-nutanix/templates/template_test.go:312
[FAILED] in [It] - /Users/deepak.muley/go/src/github.com/nutanix-cloud-native/cluster-api-provider-nutanix/templates/template_test.go:315 @ 04/11/24 14:45:52.501
• [FAILED] [60.016 seconds]
Cluster Class Template Patches Test Suite patches for failure domains [It] Control Plane NutanixMachineTemplate should not have the cluster and subnets set
/Users/deepak.muley/go/src/github.com/nutanix-cloud-native/cluster-api-provider-nutanix/templates/template_test.go:312

[FAILED] Timed out after 60.016s.
The function passed to Eventually returned the following error:
<*errors.errorString | 0xc0015133d0>:
no control plane NutanixMachineTemplate found for cluster cluster-with-failure-domains
{
s: "no control plane NutanixMachineTemplate found for cluster cluster-with-failure-domains",
}
In [It] at: /Users/deepak.muley/go/src/github.com/nutanix-cloud-native/cluster-api-provider-nutanix/templates/template_test.go:315 @ 04/11/24 14:45:52.501

Full Stack Trace
github.com/nutanix-cloud-native/cluster-api-provider-nutanix/templates.init.func1.1.3()
/Users/deepak.muley/go/src/github.com/nutanix-cloud-native/cluster-api-provider-nutanix/templates/template_test.go:315 +0x1e8

@nutanix-cn-prow-bot
Copy link

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: deepakm-ntnx, thunderboltsid

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:
  • OWNERS [deepakm-ntnx,thunderboltsid]

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

Copy link

codecov bot commented Apr 15, 2024

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 25.07%. Comparing base (25ba78f) to head (0104c28).

Additional details and impacted files
@@           Coverage Diff           @@
##             main     #410   +/-   ##
=======================================
  Coverage   25.07%   25.07%           
=======================================
  Files          19       19           
  Lines        1332     1332           
=======================================
  Hits          334      334           
  Misses        998      998           

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@deepakm-ntnx
Copy link
Contributor Author

working on following issue

Cluster Class Template Patches Test Suite patches for failure domains Control Plane NutanixMachineTemplate should not have the cluster and subnets set

/Users/deepak.muley/go/src/github.com/nutanix-cloud-native/cluster-api-provider-nutanix/templates/template_test.go:312

[FAILED] in [It] - /Users/deepak.muley/go/src/github.com/nutanix-cloud-native/cluster-api-provider-nutanix/templates/template_test.go:315 @ 04/11/24 14:45:52.501

• [FAILED] [60.016 seconds]

Cluster Class Template Patches Test Suite patches for failure domains [It] Control Plane NutanixMachineTemplate should not have the cluster and subnets set

/Users/deepak.muley/go/src/github.com/nutanix-cloud-native/cluster-api-provider-nutanix/templates/template_test.go:312

[FAILED] Timed out after 60.016s.
The function passed to Eventually returned the following error:
<*errors.errorString | 0xc0015133d0>:
no control plane NutanixMachineTemplate found for cluster cluster-with-failure-domains
{
s: "no control plane NutanixMachineTemplate found for cluster cluster-with-failure-domains",
}
In [It] at: /Users/deepak.muley/go/src/github.com/nutanix-cloud-native/cluster-api-provider-nutanix/templates/template_test.go:315 @ 04/11/24 14:45:52.501

Full Stack Trace
github.com/nutanix-cloud-native/cluster-api-provider-nutanix/templates.init.func1.1.3()
/Users/deepak.muley/go/src/github.com/nutanix-cloud-native/cluster-api-provider-nutanix/templates/template_test.go:315 +0x1e8

Seems like this problem is not showing up here again

go.mod Show resolved Hide resolved
@deepakm-ntnx
Copy link
Contributor Author

/retest

@jimmidyson
Copy link
Member

I'm confused by the tide check message: Not mergeable. Merge type "merge" disallowed by repo settings

@thunderboltsid
Copy link
Contributor

I'm confused by the tide check message: Not mergeable. Merge type "merge" disallowed by repo settings

We have explicitly disabled everything but squash and merge to avoid polluting history with unclean merges and enable easy revert of entire PRs, and I'm guessing it's just complaining because the check is expecting a non-squashed merge. We need to revisit the configuration of that tide check. cc @adiantum

@nutanix-cn-prow-bot
Copy link

nutanix-cn-prow-bot bot commented Apr 16, 2024

@deepakm-ntnx: The following tests failed, say /retest to rerun all failed tests or /retest-required to rerun all mandatory failed tests:

Test name Commit Details Required Rerun command
ci/prow/e2e-capx-controller-upgrade 0104c28 link false /test e2e-capx-controller-upgrade
ci/prow/e2e-capx-scaling 0104c28 link false /test e2e-capx-scaling

Full PR test history. Your PR dashboard.

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. I understand the commands that are listed here.

@deepakm-ntnx deepakm-ntnx merged commit 0e9a496 into main Apr 29, 2024
4 of 5 checks passed
@deepakm-ntnx deepakm-ntnx deleted the jira/krbn-8129 branch April 29, 2024 17:24
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants