Modify clusterclass patch for subnets to fix subnet cardinality and source for worker subnets #405
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
thunderboltsid
requested review from
dkoshkin and
deepakm-ntnx
and removed request for
tuxtof
deepakm-ntnx
previously approved these changes
Apr 4, 2024
The cardinality of subnets in the clusterclass was incorrect and the source of subnet for worker machine deployment was incorrect. This changes the subnet cardinality from 1 to n and changes the source of subnets for worker machine deployments to workermachinedetails variable.
thunderboltsid
force-pushed
the
jira/krbn-8122
branch
from
fd174e6 to
2cfc849
Compare
|
/retest |
deepakm-ntnx
approved these changes
Apr 4, 2024
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## main #405 +/- ##
=======================================
Coverage 25.63% 25.63%
=======================================
Files 19 19
Lines 1303 1303
=======================================
Hits 334 334
Misses 969 969 ☔ View full report in Codecov by Sentry. |
dkoshkin
approved these changes
Apr 5, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The cardinality of subnets in the clusterclass was incorrect and the source of subnet for worker machine deployment was incorrect. This changes the subnet cardinality from 1 to n and changes the source of subnets for worker machine deployments to workermachinedetails variable.