Ensure fallback config is read only when prismCentral is absent #403
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
dkoshkin
reviewed
Apr 3, 2024
yanhua121
force-pushed
the
jira/krbn-8115
branch
from
c115625 to
3858cf9
Compare
deepakm-ntnx
commented
Apr 5, 2024
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## main #403 +/- ##
=======================================
Coverage 25.63% 25.63%
=======================================
Files 19 19
Lines 1303 1303
=======================================
Hits 334 334
Misses 969 969 ☔ View full report in Codecov by Sentry. |
yanhua121
force-pushed
the
jira/krbn-8115
branch
from
3858cf9 to
d13fcc7
Compare
Skip reading fallback config file from /etc/nutanix/config/prismCentral if NutanixCluster has prismCentral set.
thunderboltsid
force-pushed
the
jira/krbn-8115
branch
from
d13fcc7 to
6af6baa
Compare
thunderboltsid
changed the title
|
/retest |
thunderboltsid
changed the title
dkoshkin
approved these changes
Apr 9, 2024
|
[APPROVALNOTIFIER] This PR is APPROVED This pull-request has been approved by: adiantum, deepakm-ntnx, dkoshkin The full list of commands accepted by this bot can be found here. The pull request process is described here
Needs approval from an approver in each of these files:
Approvers can indicate their approval by writing |
thunderboltsid
added a commit
that referenced
this pull request
Apr 10, 2024
Skip reading fallback config file from /etc/nutanix/config/prismCentral if NutanixCluster has prismCentral set. Co-authored-by: Sid Shukla <[email protected]>
thunderboltsid
added a commit
that referenced
this pull request
Apr 11, 2024
* refactor: client.go file helper methods (#360) * refactor: client.go file helper methods Refactored the existing methods and functions to be unit testable. Also made some methods that do not use the struct as generic functions. The changes were primarily an effort to add unit test coverage. * refactor: more testable read file function * test: new nutanixcluster types unit tests * test: additional test cases for errors * fixup! refactor: client.go file helper methods * fixup! refactor: client.go file helper methods * fixup! refactor: more testable read file function * fixup! refactor: client.go file helper methods * Ensure fallback config is only read when prismCentral is absent (#403) Skip reading fallback config file from /etc/nutanix/config/prismCentral if NutanixCluster has prismCentral set. Co-authored-by: Sid Shukla <[email protected]> * Update build-dev.yaml add codecov token --------- Co-authored-by: Dimitri Koshkin <[email protected]> Co-authored-by: Deepak Muley <[email protected]>
thunderboltsid
added a commit
that referenced
this pull request
May 7, 2024
Skip reading fallback config file from /etc/nutanix/config/prismCentral if NutanixCluster has prismCentral set. Co-authored-by: Sid Shukla <[email protected]>
thunderboltsid
added a commit
that referenced
this pull request
May 8, 2024
* Ensure fallback config is only read when prismCentral is absent (#403) Skip reading fallback config file from /etc/nutanix/config/prismCentral if NutanixCluster has prismCentral set. Co-authored-by: Sid Shukla <[email protected]> * Add a provision for handling image based bootstrap (#406) * Add a provision for handling image based bootstrap AHV has a limit of 32KB for cloud-init userdata. In Openshift, the ignition can be rather large (a magnitude over the limit). In order to support larger userdata files, we allow mounting the customization as an image. * Only set guestcustomization explicitly when bootstrap ref is secret * Use lowercase for data_source_reference kind. --------- Co-authored-by: Sid Shukla <[email protected]> * Introduce a nutanix prism client cache (#415) * Introduce a nutanix prism client cache The cache stores a prismgoclient.V3 client instance for each NutanixCluster instance. The cache is shared between nutanixcluster and nutanixmachine controllers. * Address review comments * Update CAPI version in go.mod This is to ensure newer versions of interfaces from SharedIndexInformers don't cause compile failures. Update go version to v1.22 becasue cmp.Or is only available in go v1.22 update prism-go-client --------- Co-authored-by: Deepak Muley <[email protected]> Co-authored-by: Yanhua Li <[email protected]>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Skip reading fallback config file from
/etc/nutanix/config/prismCentralif NutanixCluster has prismCentral set.