Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Add variable for setting the GPUs on cluster #397

Merged
merged 1 commit into from
Apr 4, 2024
Merged

Add variable for setting the GPUs on cluster #397

merged 1 commit into from
Apr 4, 2024

Conversation

thunderboltsid
Copy link
Contributor

The change also includes a patch to set the GPUs on nutanixmachinetemplate resources for control plane and worker machine deployments.

deepakm-ntnx
deepakm-ntnx previously approved these changes Mar 20, 2024
View reviewed changes
Copy link
Contributor

@deepakm-ntnx deepakm-ntnx left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

pls run gofumpt per alert

@thunderboltsid thunderboltsid force-pushed the jira/krbn-8093 branch 3 times, most recently from 1a2a86c to 12dc352 Compare April 2, 2024 14:52
@codecov Codecov
Copy link

codecov bot commented Apr 2, 2024 •
edited
Loading

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 25.63%. Comparing base (2e57c08) to head (401262f).

Additional details and impacted files 
@@           Coverage Diff           @@
##             main     #397   +/-   ##
=======================================
  Coverage   25.63%   25.63%           
=======================================
  Files          19       19           
  Lines        1303     1303           
=======================================
  Hits          334      334           
  Misses        969      969

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

dkoshkin
dkoshkin previously approved these changes Apr 2, 2024
View reviewed changes
Copy link
Contributor

@dkoshkin dkoshkin left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Good call on removing the fetch

Base automatically changed from jira/krbn-8092 to main April 3, 2024 11:49
@thunderboltsid thunderboltsid dismissed stale reviews from dkoshkin and deepakm-ntnx April 3, 2024 11:49

The base branch was changed.

@thunderboltsid
Copy link
Contributor Author

/retest

@thunderboltsid
Copy link
Contributor Author

/test e2e-capx-clusterclass

@thunderboltsid thunderboltsid force-pushed the jira/krbn-8093 branch 2 times, most recently from 3ab96e7 to e3c89d9 Compare April 3, 2024 13:00
@thunderboltsid
Copy link
Contributor Author

/retest

adiantum
adiantum previously approved these changes Apr 3, 2024
View reviewed changes
Copy link
Contributor

@adiantum adiantum left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

/lgtm
/approve
/meow

@nutanix-cn-prow-bot
Copy link

@adiantum: cat image

In response to this:

/lgtm
/approve
/meow

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

@nutanix-cn-prow-bot
Copy link

@adiantum: cat image

In response to this:

/lgtm
/approve
/meow

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

@thunderboltsid
Add variable for setting the GPUs on cluster
401262f 
The change also includes a patch to set the GPUs on
nutanixmachinetemplate resources for control plane and worker
machine deployments.
@thunderboltsid
Copy link
Contributor Author

/retest

adiantum
adiantum approved these changes Apr 4, 2024
View reviewed changes
Copy link
Contributor

@adiantum adiantum left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

/lgtm
/approve

@deepakm-ntnx
Copy link
Contributor

/lgtm
/approve

@nutanix-cn-prow-bot
Copy link

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: adiantum, deepakm-ntnx, thunderboltsid

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:
  • OWNERS [adiantum,deepakm-ntnx,thunderboltsid]

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@thunderboltsid thunderboltsid merged commit 388836c into main Apr 4, 2024
12 of 13 checks passed
@thunderboltsid thunderboltsid deleted the jira/krbn-8093 branch April 4, 2024 16:19
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@deepakm-ntnx deepakm-ntnx deepakm-ntnx approved these changes

@dkoshkin dkoshkin dkoshkin approved these changes

@adiantum adiantum adiantum approved these changes

@tuxtof tuxtof Awaiting requested review from tuxtof

@jimmidyson jimmidyson Awaiting requested review from jimmidyson

Assignees

@adiantum adiantum

@deepakm-ntnx deepakm-ntnx

Labels
approved lgtm
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
5 participants
@thunderboltsid @deepakm-ntnx @jimmidyson @adiantum @dkoshkin