Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add variable for setting the project on cluster resource #395

Merged
merged 1 commit into from
Apr 2, 2024

Conversation

thunderboltsid
Copy link
Contributor

The change also includes a patch to set the project property on nutanixmachinetemplate resources for control plane and worker machine deployments.

Copy link
Contributor

@deepakm-ntnx deepakm-ntnx left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

lets add uuid support in separate PR if needed

deepakm-ntnx
deepakm-ntnx previously approved these changes Mar 28, 2024
@deepakm-ntnx deepakm-ntnx requested a review from dkoshkin March 28, 2024 21:12
Copy link

codecov bot commented Mar 28, 2024

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 25.63%. Comparing base (51aa55f) to head (5d7c551).

Additional details and impacted files
@@           Coverage Diff           @@
##             main     #395   +/-   ##
=======================================
  Coverage   25.63%   25.63%           
=======================================
  Files          19       19           
  Lines        1303     1303           
=======================================
  Hits          334      334           
  Misses        969      969           

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

Base automatically changed from jira/krbn-8078 to main April 1, 2024 15:57
@deepakm-ntnx deepakm-ntnx dismissed their stale review April 1, 2024 15:57

The base branch was changed.

The diff also includes a patch to set the project property on
nutanixmachinetemplate resources for control plane and worker
machine deployments.
@thunderboltsid
Copy link
Contributor Author

thunderboltsid commented Apr 2, 2024

lets add uuid support in separate PR if needed

I have updated the variable to admin project instead of projectName and it now admits a type, name, and uuid instead of just a name. Also added a test case for the UUID. PTAL.

@thunderboltsid
Copy link
Contributor Author

/retest

@thunderboltsid thunderboltsid merged commit 4a18e44 into main Apr 2, 2024
12 of 13 checks passed
@thunderboltsid thunderboltsid deleted the jira/krbn-8091 branch April 2, 2024 20:52
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants