-
Notifications
You must be signed in to change notification settings - Fork 22
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Update kustomization.yaml files to new format #387
Conversation
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## main #387 +/- ##
=======================================
Coverage 25.63% 25.63%
=======================================
Files 19 19
Lines 1303 1303
=======================================
Hits 334 334
Misses 969 969 ☔ View full report in Codecov by Sentry. |
/hold |
pls hold this change till we merge https://github.com/nutanix-cloud-native/cluster-api-provider-nutanix/pull/386/files as we are changing many yamls there as well. you can assign it to me so that i can do it after that |
This changes the format of kustomization.yaml files to the ones expected by kustomize. This is pretty much an auto-generated change from kustomize linter. Can you clarify why the other PR is a blocker for this PR? |
since we are making more changes in #386 |
That makes sense. Given these changes are auto-generated anyway, it's easy enough to run the command again once the other PR is merged. |
ce7817a
to
b1e6ce8
Compare
/hold cancel |
/retest |
/test e2e-nutanix-features |
kustomize has deprecated the older format which our older kustomization files were based on. These older format files were leading to a lot of deprecation warnings from kustomize during our build processes. We used kustomize edit fix command to update our old kustomize files to our new kustomize files. This PR was largely auto-generated using the following command. ``` $ find . -type d -exec bash -c 'cd {} && kustomize edit fix' \; ```
b1e6ce8
to
82f54f1
Compare
kustomize has deprecated the older format which our older kustomization files were based on. These older format files were leading to a lot of deprecation warnings from kustomize during our build processes.
We used
kustomize edit fix
command to update our old kustomize files to our new kustomize files. This PR was largely auto-generated using the following command.