Update component versions for CAPI, Kind, and other dependencies #383

thunderboltsid · 2024-02-22T21:22:35Z

Now that our EL9 build clusters are up and running and we can use newer versions of kind to spin up bootstrap cluster, we can finally update the CAPI, Kind, and other component versions in our toolchain.

Update CAPI to v1.6.2
Update Kind to v0.22.0
Update Kubernetes client-go to v0.29.2
Update Go to v1.22.1
Update Ko to v0.15.2
Update kubernetes-controller-tools to 0.13.0
Update customise to v5.3.0
Update yamllint to v1.3.5

Due to modification of versions certain small code changes had to account for new constants and function signatures in newer dependencies. However that triggered failures in our codecov as a lot of these changes were in main.go. As a result, main.go had to be refactored to be more unit-testable to increase code coverage to hit the patch coverage prerequisite.

Note: --metrics-bind-address flag has been removed and --diagnostics-address and --insecure-diagnostics have been added instead.

How has this been tested?

Prior to adding new EL9 build-clusters to our prow infra, the e2es were failing for this PR. Update component versions for CAPI, Kind, and other dependencies #383 (comment)
After adding new EL9 build-clusters to our prow infra, the same e2es are passing for this PR.

thunderboltsid · 2024-02-22T21:22:41Z

/hold

codecov · 2024-02-23T02:13:29Z

Codecov Report

Attention: Patch coverage is 76.19048% with 15 lines in your changes are missing coverage. Please review.

Project coverage is 25.63%. Comparing base (55e8e38) to head (1c95fc9).

Files	Patch %	Lines
main.go	77.58%	13 Missing ⚠️
controllers/nutanixmachine_controller.go	0.00%	2 Missing ⚠️

Additional details and impacted files

@@            Coverage Diff             @@
##             main     #383      +/-   ##
==========================================
+ Coverage   20.37%   25.63%   +5.25%     
==========================================
  Files          17       19       +2     
  Lines        1212     1303      +91     
==========================================
+ Hits          247      334      +87     
- Misses        965      969       +4

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

thunderboltsid · 2024-02-23T02:15:14Z

/retest

thunderboltsid · 2024-02-23T09:02:03Z

This is the underlying failure before the CI build cluster upgrade

INFO: Creating a kind cluster with name "test-q1ktgr"
Creating cluster "test-q1ktgr" ...
 • Ensuring node image (kindest/node:v1.27.1) 🖼  ...
 ✓ Ensuring node image (kindest/node:v1.27.1) 🖼
 • Preparing nodes 📦   ...
 ✗ Preparing nodes 📦 
  INFO: Failed to collect logs from kind: [command "docker exec --privileged test-q1ktgr-control-plane sh -c 'tar --hard-dereference -C /var/log/ -chf - . || (r=$?; [ $r -eq 1 ] || exit $r)'" failed with error: exit status 1, [command "docker exec --privileged test-q1ktgr-control-plane journalctl --no-pager -u kubelet.service" failed with error: exit status 1, command "docker exec --privileged test-q1ktgr-control-plane journalctl --no-pager" failed with error: exit status 1, command "docker exec --privileged test-q1ktgr-control-plane crictl images" failed with error: exit status 1, command "docker exec --privileged test-q1ktgr-control-plane journalctl --no-pager -u containerd.service" failed with error: exit status 1, command "docker exec --privileged test-q1ktgr-control-plane cat /kind/version" failed with error: exit status 1]]
  �[38;5;9m[FAILED]�[0m in [SynchronizedBeforeSuite] - /home/prow/go/pkg/mod/sigs.k8s.io/cluster-api/[email protected]/framework/bootstrap/kind_provider.go:183 �[38;5;243m@ 02/23/24 02:22:51.838�[0m
�[38;5;9m[SynchronizedBeforeSuite] [FAILED] [56.569 seconds]�[0m
�[38;5;9m�[1m[SynchronizedBeforeSuite] �[0m
�[38;5;243m/home/prow/go/src/github.com/nutanix-cloud-native/cluster-api-provider-nutanix/test/e2e/e2e_suite_test.go:63�[0m

  �[38;5;9m[FAILED] Failed to create kind cluster "test-q1ktgr": command "docker run --name test-q1ktgr-control-plane --hostname test-q1ktgr-control-plane --label io.x-k8s.kind.role=control-plane --privileged --security-opt seccomp=unconfined --security-opt apparmor=unconfined --tmpfs /tmp --tmpfs /run --volume /var --volume /lib/modules:/lib/modules:ro -e KIND_EXPERIMENTAL_CONTAINERD_SNAPSHOTTER --detach --tty --label io.x-k8s.kind.cluster=test-q1ktgr --net kind --restart=on-failure:1 --init=false --cgroupns=private --publish=127.0.0.1:43709:6443/TCP -e KUBECONFIG=/etc/kubernetes/admin.conf kindest/node:v1.27.1" failed with error: exit status 125
  WARNING: Your kernel does not support cgroup namespaces.  Cgroup namespace setting discarded.
  125a72046af9e1b497c484ed5327bc245fee1ec2d935fdbae313d777bd7b6b64
  docker: Error response from daemon: OCI runtime create failed: cgroup namespaces aren't enabled in the kernel: unknown.

Next week we are planning on adding a new build cluster to prow that's a EL9 NKE-X which shouldn't have this issue.

thunderboltsid · 2024-03-07T19:33:14Z

/hold cancel

thunderboltsid · 2024-03-07T20:09:35Z

/test e2e-capx-conformance

thunderboltsid · 2024-03-07T21:38:57Z

/test e2e-k8s-upgrade

thunderboltsid · 2024-03-07T21:48:31Z

/test e2e-capx-controller-upgrade

main.go

thunderboltsid · 2024-03-07T22:45:26Z

/retest

thunderboltsid · 2024-03-07T23:21:29Z

/hold

api/v1alpha4/nutanixcluster_conversion.go

api/v1beta1/nutanixcluster_validate_test.go

config/default/manager_auth_proxy_patch.yaml

api/v1alpha4/nutanixcluster_conversion.go

controllers/nutanixmachine_controller.go

main.go

test/e2e/projects_test.go

api/v1alpha4/nutanixcluster_conversion.go

- Move from k8s.io/utils/pointer to k8s.io/utils/ptr as pointer will be deprecated in the coming release.

thunderboltsid · 2024-03-08T12:30:30Z

/retest

thunderboltsid · 2024-03-08T15:58:40Z

/test e2e-capx-conformance

thunderboltsid · 2024-03-08T20:41:04Z

the PE credentials had expired causing CSI failures and had to be rotated.
/test e2e-capx-conformance

thunderboltsid · 2024-03-08T22:26:47Z

/hold cancel

thunderboltsid · 2024-03-11T13:34:18Z

/retest

.github/workflows/build-dev.yaml

Makefile

api/v1alpha4/nutanixcluster_conversion.go

deepakm-ntnx · 2024-03-11T17:47:20Z

@thunderboltsid assuming we did verify with following:

test/e2e/config/nutanix.yaml

thunderboltsid · 2024-03-11T23:29:25Z

/retest

thunderboltsid · 2024-03-12T00:00:36Z

/test e2e-k8s-conformance

tuxtof

/lgtm /approve

nutanix-cn-prow-bot bot added the do-not-merge/hold label Feb 22, 2024

nutanix-cn-prow-bot bot requested review from adiantum and yannickstruyf3 February 22, 2024 21:23

thunderboltsid changed the title ~~Update test/e2e/config/nutanix.yaml~~ [WIP] Update test/e2e/config/nutanix.yaml Feb 22, 2024

thunderboltsid force-pushed the jira/krbn-7870 branch 4 times, most recently from 9bbdd57 to 4d037c8 Compare March 7, 2024 19:30

thunderboltsid changed the title ~~[WIP] Update test/e2e/config/nutanix.yaml~~ Update component versions for devbox dependencies Mar 7, 2024

nutanix-cn-prow-bot bot removed the do-not-merge/hold label Mar 7, 2024

thunderboltsid force-pushed the jira/krbn-7870 branch 2 times, most recently from 59074fb to 9dccdc7 Compare March 7, 2024 19:50

thunderboltsid changed the title ~~Update component versions for devbox dependencies~~ Update component versions for CAPI, Kind, and other dependencies Mar 7, 2024

thunderboltsid force-pushed the jira/krbn-7870 branch from 9dccdc7 to 4c3a439 Compare March 7, 2024 22:23

thunderboltsid commented Mar 7, 2024

View reviewed changes

main.go Show resolved Hide resolved

nutanix-cn-prow-bot bot added the do-not-merge/hold label Mar 7, 2024

thunderboltsid force-pushed the jira/krbn-7870 branch from 4c3a439 to bffca74 Compare March 8, 2024 00:31

thunderboltsid commented Mar 8, 2024

View reviewed changes

api/v1alpha4/nutanixcluster_conversion.go Outdated Show resolved Hide resolved

thunderboltsid commented Mar 8, 2024

View reviewed changes

api/v1beta1/nutanixcluster_validate_test.go Show resolved Hide resolved

thunderboltsid commented Mar 8, 2024

View reviewed changes

config/default/manager_auth_proxy_patch.yaml Show resolved Hide resolved

dkoshkin reviewed Mar 8, 2024

View reviewed changes

thunderboltsid added 3 commits March 8, 2024 11:45

Use nolintlint for enforcing nolint comments

1672c90

Address review comments

437c4c1

- Move from k8s.io/utils/pointer to k8s.io/utils/ptr as pointer will be deprecated in the coming release.

Update kubernetes dependencies to v0.29.2

935ae25

thunderboltsid requested a review from dkoshkin March 8, 2024 12:30

nutanix-cn-prow-bot bot removed the do-not-merge/hold label Mar 8, 2024

thunderboltsid force-pushed the jira/krbn-7870 branch from 7c40df7 to bb65336 Compare March 11, 2024 02:46

Add some unit tests to get above coverage requirements

56e6a3c

thunderboltsid force-pushed the jira/krbn-7870 branch from bb65336 to 56e6a3c Compare March 11, 2024 13:25