Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Change target Github branches for Github Actions #379

Merged
merged 1 commit into from
Feb 9, 2024

Conversation

thunderboltsid
Copy link
Contributor

@thunderboltsid thunderboltsid commented Feb 9, 2024

The actions would previously run against PRs that were based against the main branch. They should run on any PR against any branch. The Push triggers should be limited to main and 'release-*' branches.

tuxtof
tuxtof previously approved these changes Feb 9, 2024
Copy link
Contributor

@tuxtof tuxtof left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

/lgtm

Copy link

codecov bot commented Feb 9, 2024

Codecov Report

All modified and coverable lines are covered by tests ✅

Comparison is base (3fa9d45) 20.37% compared to head (2db71ee) 20.37%.

Additional details and impacted files
@@           Coverage Diff           @@
##             main     #379   +/-   ##
=======================================
  Coverage   20.37%   20.37%           
=======================================
  Files          17       17           
  Lines        1212     1212           
=======================================
  Hits          247      247           
  Misses        965      965           

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@thunderboltsid
Copy link
Contributor Author

/hold

The actions would previously run against PRs that were based against
the main branch. They should run on any PR against any branch.
@thunderboltsid
Copy link
Contributor Author

/unhold

@tuxtof
Copy link
Contributor

tuxtof commented Feb 9, 2024

/approve

1 similar comment
@yannickstruyf3
Copy link
Contributor

/approve

@nutanix-cn-prow-bot
Copy link

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: thunderboltsid, tuxtof, yannickstruyf3

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:
  • OWNERS [thunderboltsid,tuxtof,yannickstruyf3]

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@thunderboltsid thunderboltsid merged commit 304d0d7 into main Feb 9, 2024
7 checks passed
@thunderboltsid thunderboltsid deleted the jira/krbn-7990 branch February 9, 2024 11:19
thunderboltsid added a commit that referenced this pull request Feb 9, 2024
The actions would previously run against PRs that were based against
the main branch. They should run on any PR against any branch.
thunderboltsid added a commit that referenced this pull request Feb 9, 2024
The actions would previously run against PRs that were based against
the main branch. They should run on any PR against any branch.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants