-
Notifications
You must be signed in to change notification settings - Fork 22
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Cherry-pick PR #369 to release-v1.3 #375
Conversation
/hold |
/test e2e-capx-controller-upgrade |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
/ok-to-test
/retest |
/test e2e-capx-conformance |
@thunderboltsid: The specified target(s) for
Use In response to this:
Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. |
/test e2e-capx-conformance |
/test e2e-k8s-upgrade |
1 similar comment
/test e2e-k8s-upgrade |
/unhold |
/hold |
/unhold |
38cbadb
38cbadb
to
ca50732
Compare
ca50732
to
ef660d8
Compare
✅ None of your dependencies violate policy! |
Needed to merge #380 first to ensure tests here can run as expected. |
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## release-v1.3 #375 +/- ##
=============================================
Coverage 12.53% 12.53%
=============================================
Files 20 20
Lines 2003 2003
=============================================
Hits 251 251
Misses 1752 1752 ☔ View full report in Codecov by Sentry. |
/retest |
/hold |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
/lgtm
/unhold |
/approve |
[APPROVALNOTIFIER] This PR is APPROVED This pull-request has been approved by: thunderboltsid, tuxtof, yannickstruyf3 The full list of commands accepted by this bot can be found here. The pull request process is described here
Needs approval from an approver in each of these files:
Approvers can indicate their approval by writing |
Cherry-Pick Details