Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Cherry-pick PR #369 to release-v1.3 #375

Merged
merged 1 commit into from
Feb 9, 2024
Merged

Conversation

thunderboltsid
Copy link
Contributor

@thunderboltsid thunderboltsid commented Feb 7, 2024

Cherry-Pick Details

@thunderboltsid
Copy link
Contributor Author

/hold

@thunderboltsid
Copy link
Contributor Author

/test e2e-capx-controller-upgrade

tuxtof
tuxtof previously approved these changes Feb 7, 2024
Copy link
Contributor

@tuxtof tuxtof left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

/ok-to-test

yannickstruyf3
yannickstruyf3 previously approved these changes Feb 7, 2024
@thunderboltsid
Copy link
Contributor Author

/retest

@thunderboltsid
Copy link
Contributor Author

/test e2e-capx-conformance

@nutanix-cn-prow-bot
Copy link

@thunderboltsid: The specified target(s) for /test were not found.
The following commands are available to trigger optional jobs:

  • /test e2e-capx-controller-upgrade

Use /test all to run all jobs.

In response to this:

/test e2e-capx-conformance

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

@thunderboltsid
Copy link
Contributor Author

/test e2e-capx-conformance

@thunderboltsid
Copy link
Contributor Author

/test e2e-k8s-upgrade

1 similar comment
@thunderboltsid
Copy link
Contributor Author

/test e2e-k8s-upgrade

@thunderboltsid
Copy link
Contributor Author

/unhold

@thunderboltsid
Copy link
Contributor Author

/hold

@thunderboltsid
Copy link
Contributor Author

/unhold

@thunderboltsid thunderboltsid changed the title Cherry-pick (#369) Cherry-pick PR #369 to release-v1.3 Feb 9, 2024
@thunderboltsid thunderboltsid reopened this Feb 9, 2024
@thunderboltsid thunderboltsid dismissed stale reviews from yannickstruyf3 and tuxtof via 38cbadb February 9, 2024 11:49
Copy link

github-actions bot commented Feb 9, 2024

✅ None of your dependencies violate policy!

@thunderboltsid
Copy link
Contributor Author

thunderboltsid commented Feb 9, 2024

Needed to merge #380 first to ensure tests here can run as expected.

Copy link

codecov bot commented Feb 9, 2024

Codecov Report

All modified and coverable lines are covered by tests ✅

Comparison is base (3954b3d) 12.53% compared to head (ef660d8) 12.53%.

Additional details and impacted files
@@              Coverage Diff              @@
##           release-v1.3     #375   +/-   ##
=============================================
  Coverage         12.53%   12.53%           
=============================================
  Files                20       20           
  Lines              2003     2003           
=============================================
  Hits                251      251           
  Misses             1752     1752           

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@thunderboltsid
Copy link
Contributor Author

/retest

@thunderboltsid
Copy link
Contributor Author

/hold

Copy link
Contributor

@tuxtof tuxtof left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

/lgtm

@thunderboltsid
Copy link
Contributor Author

/unhold

@yannickstruyf3
Copy link
Contributor

/approve

@nutanix-cn-prow-bot
Copy link

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: thunderboltsid, tuxtof, yannickstruyf3

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:
  • OWNERS [thunderboltsid,tuxtof,yannickstruyf3]

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@thunderboltsid thunderboltsid merged commit d0ec5c3 into release-v1.3 Feb 9, 2024
11 checks passed
@thunderboltsid thunderboltsid deleted the jira/krbn-7956 branch February 9, 2024 15:14
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants