Update Linter usage in project #373
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
thunderboltsid
force-pushed
the
jira/krbn-7968
branch
from
9e31880 to
2a5ab07
Compare
thunderboltsid
changed the title
thunderboltsid
force-pushed
the
jira/krbn-7968
branch
from
2a5ab07 to
d0b5381
Compare
Most of these were extraneous whitespace or lack of newlines.
thunderboltsid
force-pushed
the
jira/krbn-7968
branch
from
d0b5381 to
c9ff756
Compare
✅ None of your dependencies violate policy! |
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## main #373 +/- ##
==========================================
+ Coverage 15.21% 15.24% +0.02%
==========================================
Files 18 18
Lines 1209 1207 -2
==========================================
Hits 184 184
+ Misses 1025 1023 -2 ☔ View full report in Codecov by Sentry. |
|
/retest |
|
[APPROVALNOTIFIER] This PR is APPROVED This pull-request has been approved by: adiantum, thunderboltsid The full list of commands accepted by this bot can be found here. The pull request process is described here
Needs approval from an approver in each of these files:
Approvers can indicate their approval by writing |
yannickstruyf3
approved these changes
Jan 26, 2024
|
/hold |
|
/test e2e-capx-controller-upgrade |
|
/hold cancel |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Linting targets weren't included in build processes making way for unlinted go and yaml files in the codebase.
This PR add the linters in place using golangci-lint and yamllint and fixes the linting errors highlighted.