Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add a QuickStart e2e with cluster class #371

Merged

Conversation

deepakm-ntnx
Copy link
Contributor

What this PR does / why we need it:

Which issue(s) this PR fixes (optional, in fixes #<issue number>(, fixes #<issue_number>, ...) format, will close the issue(s) when PR gets merged):
Fixes #

How Has This Been Tested?:

git push origin HEAD:quickstart-clusterclass
When following the Cluster API quick-start with ClusterClass Should create a workload cluster [quickstart2, capx-feature-test]
/Users/deepak.muley/go/src/github.com/kubernetes-sigs/cluster-api/test/e2e/quick_start.go:78
  STEP: Creating a namespace for hosting the "quick-start" test spec @ 01/24/24 15:15:32.709
  INFO: Creating namespace quick-start-mcxuvt
  INFO: Creating event watcher for namespace "quick-start-mcxuvt"
  STEP: Creating a workload cluster @ 01/24/24 15:15:32.76
  INFO: Creating the workload cluster with name "quick-start-q2yn0a" using the "topology" template (Kubernetes v1.27.9, 1 control-plane machines, 1 worker machines)
  INFO: Getting the cluster template yaml
  INFO: clusterctl config cluster quick-start-q2yn0a --infrastructure (default) --kubernetes-version v1.27.9 --control-plane-machine-count 1 --worker-machine-count 1 --flavor topology
  INFO: Applying the cluster template yaml to the cluster
configmap/quick-start-q2yn0a-pc-trusted-ca-bundle created
configmap/nutanix-ccm created
secret/quick-start-q2yn0a created
secret/nutanix-ccm-secret created
clusterresourceset.addons.cluster.x-k8s.io/nutanix-ccm-crs created
kubeadmconfigtemplate.bootstrap.cluster.x-k8s.io/quick-start-q2yn0a-kcfg-0 created
clusterclass.cluster.x-k8s.io/e2e created
kubeadmcontrolplanetemplate.controlplane.cluster.x-k8s.io/e2e-kcpt created
nutanixclustertemplate.infrastructure.cluster.x-k8s.io/e2e-nct created
nutanixmachinetemplate.infrastructure.cluster.x-k8s.io/e2e-cp-nmt created
nutanixmachinetemplate.infrastructure.cluster.x-k8s.io/e2e-md-nmt created
configmap/cni-quick-start-q2yn0a-crs-cni created
clusterresourceset.addons.cluster.x-k8s.io/quick-start-q2yn0a-crs-cni created
cluster.cluster.x-k8s.io/quick-start-q2yn0a created

  INFO: Waiting for the cluster infrastructure to be provisioned
  STEP: Waiting for cluster to enter the provisioned phase @ 01/24/24 15:15:36.261
  INFO: Waiting for control plane to be initialized
  INFO: Waiting for the first control plane machine managed by quick-start-mcxuvt/quick-start-q2yn0a-r9dr6 to be provisioned
  STEP: Waiting for one control plane node to exist @ 01/24/24 15:15:46.349
  INFO: Waiting for control plane to be ready
  INFO: Waiting for control plane quick-start-mcxuvt/quick-start-q2yn0a-r9dr6 to be ready (implies underlying nodes to be ready as well)
  STEP: Waiting for the control plane to be ready @ 01/24/24 15:16:46.437
  STEP: Checking all the control plane machines are in the expected failure domains @ 01/24/24 15:16:46.441
  INFO: Waiting for the machine deployments to be provisioned
  STEP: Waiting for the workload nodes to exist @ 01/24/24 15:16:46.464
  STEP: Checking all the machines controlled by quick-start-q2yn0a-md-0-xdfwp are in the "" failure domain @ 01/24/24 15:17:16.515
  INFO: Waiting for the machine pools to be provisioned
  STEP: PASSED! @ 01/24/24 15:17:16.558
  STEP: Dumping logs from the "quick-start-q2yn0a" workload cluster @ 01/24/24 15:17:16.558
Failed to get logs for Machine quick-start-q2yn0a-md-0-xdfwp-mwlt7-7sr6f, Cluster quick-start-mcxuvt/quick-start-q2yn0a: error creating container exec: Error response from daemon: No such container: quick-start-q2yn0a-md-0-xdfwp-mwlt7-7sr6f
Failed to get logs for Machine quick-start-q2yn0a-r9dr6-pw74q, Cluster quick-start-mcxuvt/quick-start-q2yn0a: error creating container exec: Error response from daemon: No such container: quick-start-q2yn0a-r9dr6-pw74q
  STEP: Dumping all the Cluster API resources in the "quick-start-mcxuvt" namespace @ 01/24/24 15:17:16.722
  STEP: Deleting cluster quick-start-mcxuvt/quick-start-q2yn0a @ 01/24/24 15:17:17.181
  STEP: Deleting cluster quick-start-q2yn0a @ 01/24/24 15:17:17.215
  INFO: Waiting for the Cluster quick-start-mcxuvt/quick-start-q2yn0a to be deleted
  STEP: Waiting for cluster quick-start-q2yn0a to be deleted @ 01/24/24 15:17:17.23
  STEP: Deleting namespace used for hosting the "quick-start" test spec @ 01/24/24 15:17:47.265
  INFO: Deleting namespace quick-start-mcxuvt
• [134.581 seconds]

Please describe the tests that you ran to verify your changes. Provide instructions so we can reproduce. Please also list any relevant details for your test configuration and test output

Special notes for your reviewer:

Please confirm that if this PR changes any image versions, then that's the sole change this PR makes.

Release note:


Copy link

codecov bot commented Jan 24, 2024

Codecov Report

All modified and coverable lines are covered by tests ✅

Comparison is base (8c8d118) 15.21% compared to head (dc8e505) 15.21%.

Additional details and impacted files
@@           Coverage Diff           @@
##             main     #371   +/-   ##
=======================================
  Coverage   15.21%   15.21%           
=======================================
  Files          18       18           
  Lines        1209     1209           
=======================================
  Hits          184      184           
  Misses       1025     1025           

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@thunderboltsid
Copy link
Contributor

/retest

@deepakm-ntnx
Copy link
Contributor Author

/test e2e-capx-controller-upgrade

Copy link
Contributor

@dkoshkin dkoshkin left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

As long as the e2e tests are passing in CI, this LGTM!

@thunderboltsid thunderboltsid changed the title Quickstart clusterclass Add a QuickStart e2e with cluster class Jan 26, 2024
@thunderboltsid
Copy link
Contributor

/lgtm
/approve

@nutanix-cn-prow-bot
Copy link

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: deepakm-ntnx, dkoshkin, thunderboltsid

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:
  • OWNERS [deepakm-ntnx,thunderboltsid]

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@thunderboltsid thunderboltsid merged commit cca8316 into nutanix-cloud-native:main Jan 26, 2024
8 of 10 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants