Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Check-in v1.3.0 manifests in test/e2e/data #367

Merged
merged 1 commit into from
Jan 18, 2024
Merged

Check-in v1.3.0 manifests in test/e2e/data #367

merged 1 commit into from
Jan 18, 2024

Conversation

thunderboltsid
Copy link
Contributor

@thunderboltsid thunderboltsid commented Jan 18, 2024

v1.3.0 manifests are to to spin up a point in time infrastructure from
a particular release. We also updated the versions to ensure there's a
version that e2e tests can target. We have also added a
'release-blocker' comment everywhere that needs to be modified to ensure
a release does not break e2es.

Copy link

codecov bot commented Jan 18, 2024

Codecov Report

All modified and coverable lines are covered by tests ✅

Comparison is base (72058b8) 15.21% compared to head (458fbad) 15.21%.

Additional details and impacted files
@@           Coverage Diff           @@
##             main     #367   +/-   ##
=======================================
  Coverage   15.21%   15.21%           
=======================================
  Files          18       18           
  Lines        1209     1209           
=======================================
  Hits          184      184           
  Misses       1025     1025           

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@thunderboltsid
Copy link
Contributor Author

/retest

1 similar comment
@thunderboltsid
Copy link
Contributor Author

/retest

@thunderboltsid
Copy link
Contributor Author

/retest

@thunderboltsid
Copy link
Contributor Author

/hold

v1.3.0 manifests are to to spin up a point in time infrastructure from
a particular release. We also updated the versions to ensure there's a
version that e2e tests can target. We have also added a
'release-blocker' comment everywhere that needs to be modified to ensure
a release does not break e2es.
Copy link

✅ None of your dependencies violate policy!

@thunderboltsid
Copy link
Contributor Author

/retest

@deepakm-ntnx
Copy link
Contributor

@thunderboltsid
Copy link
Contributor Author

thunderboltsid commented Jan 18, 2024

@deepakm-ntnx
Copy link
Contributor

https://github.com/search?q=repo%3Anutanix-cloud-native%2Fcluster-api-provider-nutanix%20v1.2.4&type=code

Good catch, does it need to be in the same change?

Preferred so that we can make this as a ref PR listing all the changes we need to make during every release?

Copy link
Contributor

@adiantum adiantum left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

/lgtm
/approve

@faiq
Copy link
Contributor

faiq commented Jan 18, 2024

/lgtm
/approve

@nutanix-cn-prow-bot
Copy link

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: adiantum, faiq, thunderboltsid

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:
  • OWNERS [adiantum,thunderboltsid]

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@adiantum
Copy link
Contributor

we need to update test code as well. pls see ref to 1.2.4 https://github.com/search?q=repo%3Anutanix-cloud-native%2Fcluster-api-provider-nutanix%20v1.2.4&type=code

Actually we don't need to do it.
We can add additional test with additional version if required

Makefile Show resolved Hide resolved
@thunderboltsid
Copy link
Contributor Author

/unhold

@thunderboltsid thunderboltsid merged commit 43b112e into main Jan 18, 2024
12 checks passed
@thunderboltsid thunderboltsid deleted the fix-e2e branch January 18, 2024 21:09
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants