-
Notifications
You must be signed in to change notification settings - Fork 22
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Check-in v1.3.0 manifests in test/e2e/data #367
Conversation
60e7ee8
to
c131a04
Compare
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## main #367 +/- ##
=======================================
Coverage 15.21% 15.21%
=======================================
Files 18 18
Lines 1209 1209
=======================================
Hits 184 184
Misses 1025 1025 ☔ View full report in Codecov by Sentry. |
/retest |
1 similar comment
/retest |
c131a04
to
2099246
Compare
/retest |
2099246
to
d2a645a
Compare
/hold |
d2a645a
to
e6d7359
Compare
v1.3.0 manifests are to to spin up a point in time infrastructure from a particular release. We also updated the versions to ensure there's a version that e2e tests can target. We have also added a 'release-blocker' comment everywhere that needs to be modified to ensure a release does not break e2es.
e6d7359
to
458fbad
Compare
✅ None of your dependencies violate policy! |
/retest |
we need to update test code as well. pls see ref to 1.2.4 https://github.com/search?q=repo%3Anutanix-cloud-native%2Fcluster-api-provider-nutanix%20v1.2.4&type=code |
Good catch, does it need to be in the same change? |
Preferred so that we can make this as a ref PR listing all the changes we need to make during every release? |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
/lgtm
/approve
/lgtm |
[APPROVALNOTIFIER] This PR is APPROVED This pull-request has been approved by: adiantum, faiq, thunderboltsid The full list of commands accepted by this bot can be found here. The pull request process is described here
Needs approval from an approver in each of these files:
Approvers can indicate their approval by writing |
Actually we don't need to do it. |
/unhold |
v1.3.0 manifests are to to spin up a point in time infrastructure from
a particular release. We also updated the versions to ensure there's a
version that e2e tests can target. We have also added a
'release-blocker' comment everywhere that needs to be modified to ensure
a release does not break e2es.