Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Adding support for Enter key on MacOS and closing #167 #168

Merged
merged 1 commit into from
Jan 29, 2024

Conversation

smithkyle
Copy link
Contributor

adds support for numpad Enter key on macos, differentiates between return/enter keys, and removes duplicate lines closes #167

…turn/enter keys, and removes duplicate lines closes nut-tree#167
@smithkyle
Copy link
Contributor Author

I've been searching high and low for keycodes for Windows and X11 - just about everything I've seen says that they don't differentiate between return and enter on the keypad...however, I just now came across a possible keycode for X11: XK_KP_Enter per this site. I'm not sure if that is correct though - I know you had found an additional keycode for my last PR, so I'm not sure what you use as your source for keycodes.

@smithkyle
Copy link
Contributor Author

Also, how would I test this locally? I know that I can use npm link to pull the local libnut package in to my local nut.js repo, but what about the libnut-{platform} packages? Would I run the build scripts to generate those packages and then npm link them into my local nut.js repo?

@s1hofmann
Copy link
Member

@smithkyle The platform dependent packages of libnut make it a bit hard, since they are generated via CI. The easiest way for now would be to do an npm install in your nut.js repo, then replace the platform specific binary you built on your machine in your respective node_modules folder

@smithkyle
Copy link
Contributor Author

👍🏻 that's exactly what did 😀 let me know about the x11 enter keycode

@smithkyle
Copy link
Contributor Author

Hello! Hope you're doing well. I know you've been busy - just wanted to bump this up.

@s1hofmann s1hofmann merged commit ebf8343 into nut-tree:develop Jan 29, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Duplicate key entires?
2 participants