-
Notifications
You must be signed in to change notification settings - Fork 323
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
modify calculation of week type #3870
Conversation
The latest updates on your projects. Learn more about Vercel for Git ↗︎
|
@kaze-droid is attempting to deploy a commit to the modsbot's projects Team on Vercel. A member of the Team first needs to authorize it. |
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## master #3870 +/- ##
==========================================
+ Coverage 54.52% 54.68% +0.15%
==========================================
Files 274 274
Lines 6076 6099 +23
Branches 1455 1460 +5
==========================================
+ Hits 3313 3335 +22
- Misses 2763 2764 +1 ☔ View full report in Codecov by Sentry. 🚨 Try these New Features:
|
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thanks for the PR! This looks like a reasonable implementation to me for this edge case. I'll add to the comments here and there and get this merged.
Context
Resolves Issue #3869
Implementation
Check if its a weekend on special acad weeks (recess, reading, examination) before returning the weekType