Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

modify calculation of week type #3870

Merged
merged 5 commits into from
Nov 25, 2024

Conversation

kaze-droid
Copy link
Contributor

Context

Resolves Issue #3869

Implementation

Check if its a weekend on special acad weeks (recess, reading, examination) before returning the weekType

Copy link

vercel bot commented Nov 23, 2024

The latest updates on your projects. Learn more about Vercel for Git ↗︎

Name Status Preview Comments Updated (UTC)
nusmods-export ✅ Ready (Inspect) Visit Preview 💬 Add feedback Nov 25, 2024 3:51pm
nusmods-website ✅ Ready (Inspect) Visit Preview 💬 Add feedback Nov 25, 2024 3:51pm

Copy link

vercel bot commented Nov 23, 2024

@kaze-droid is attempting to deploy a commit to the modsbot's projects Team on Vercel.

A member of the Team first needs to authorize it.

Copy link

codecov bot commented Nov 23, 2024

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 54.68%. Comparing base (988c6fd) to head (a3b710a).
Report is 21 commits behind head on master.

Additional details and impacted files
@@            Coverage Diff             @@
##           master    #3870      +/-   ##
==========================================
+ Coverage   54.52%   54.68%   +0.15%     
==========================================
  Files         274      274              
  Lines        6076     6099      +23     
  Branches     1455     1460       +5     
==========================================
+ Hits         3313     3335      +22     
- Misses       2763     2764       +1     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.


🚨 Try these New Features:

Copy link
Member

@kokrui kokrui left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks for the PR! This looks like a reasonable implementation to me for this edge case. I'll add to the comments here and there and get this merged.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants