Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix modules in Special Term do not show up in Today page #3814

Conversation

xinyuwang-nus
Copy link
Contributor

@xinyuwang-nus xinyuwang-nus commented Aug 28, 2024

Context

#3757
#3830

Implementation

Other Information

Copy link

vercel bot commented Aug 28, 2024

The latest updates on your projects. Learn more about Vercel for Git ↗︎

Name Status Preview Comments Updated (UTC)
nusmods-export ✅ Ready (Inspect) Visit Preview 💬 Add feedback Oct 16, 2024 6:27am
nusmods-website ✅ Ready (Inspect) Visit Preview 💬 Add feedback Oct 16, 2024 6:27am

Copy link

vercel bot commented Aug 28, 2024

@xinyuwang-nus is attempting to deploy a commit to the modsbot's projects Team on Vercel.

A member of the Team first needs to authorize it.

Copy link

codecov bot commented Sep 12, 2024

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 54.88%. Comparing base (2d4743d) to head (d8e1e39).
Report is 39 commits behind head on master.

Additional details and impacted files
@@            Coverage Diff             @@
##           master    #3814      +/-   ##
==========================================
+ Coverage   53.87%   54.88%   +1.00%     
==========================================
  Files         274      274              
  Lines        6032     6071      +39     
  Branches     1449     1455       +6     
==========================================
+ Hits         3250     3332      +82     
+ Misses       2782     2739      -43     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

Copy link
Member

@ravern ravern left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Sorry for the delay in reviewing this!

I've added #3757 (comment) after doing a deep dive into the issue.

I'm good to merge this once the linting errors are fixed, since this solves the issue for now. You can find the linting errors by clicking the "Details" link in the failing "build_and_test" workflow, then navigating to the "Tests" tab.

Here's a direct link to that page: https://app.circleci.com/pipelines/github/nusmodifications/nusmods/14863/workflows/fc3ce863-17e5-49a2-84e9-2d99e12ab411/jobs/89894/tests

@xinyuwang-nus xinyuwang-nus changed the title weeks of classes checking on today dashboard Fix Modules in Special Term do not show up in Today page Oct 9, 2024
Copy link
Member

@ravern ravern left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM, thank you for addressing this issue! Definitely not a trivial one to solve.

@ravern ravern changed the title Fix Modules in Special Term do not show up in Today page Fix modules in Special Term do not show up in Today page Oct 16, 2024
@ravern ravern merged commit 74c53a9 into nusmodifications:master Oct 16, 2024
6 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants