feat(search): add grading basis filter to module list #3666
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
The latest updates on your projects. Learn more about Vercel for Git ↗︎
|
|
@chew01 is attempting to deploy a commit to a Personal Account owned by @nusmodifications on Vercel. @nusmodifications first needs to authorize it. |
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## master #3666 +/- ##
=======================================
Coverage 53.94% 53.94%
=======================================
Files 272 272
Lines 5963 5963
Branches 1420 1420
=======================================
Hits 3217 3217
Misses 2746 2746 ☔ View full report in Codecov by Sentry. |
ravern
changed the title
ravern
changed the title
ravern
reviewed
Mar 13, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Context
Closes #3664
Implementation
Add gradingBasisDescription to ModuleInformation type in scraper (and frontend for consistency)
Information is expected to be sent to Elastic client for indexing.
Updated view to reflect changes.
Other Information
I'm not familiar with Elastic API and certainly unable to see the endpoint format available so will need core team to review.
Let me know if adding field ModuleInformation is insufficient and explicit indexing is required. Thanks 🙌