Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

MPE: Add FAQ and fix crashing module details fetch #3261

Merged
merged 3 commits into from
Mar 3, 2021

Conversation

taneliang
Copy link
Member

Context

#3035. Details in email and our private NUSMods Telegram group (sorry everyone else! We're trying to ship this asap. Would be happy to explain the context if you comment)

@vercel
Copy link

vercel bot commented Mar 3, 2021

This pull request is being automatically deployed with Vercel (learn more).
To see the status of your deployments, click below or on the icon next to each commit.

nusmods-website – ./website

🔍 Inspect: https://vercel.com/nusmodifications/nusmods-website/69Nn94GUqy1HDbECwaSydkU1bGx6
✅ Preview: https://nusmods-websit-git-eliang-mpe-faq-and-fetch-fix-nusmodif-5edea8.vercel.app

nusmods-export – ./export

🔍 Inspect: https://vercel.com/nusmodifications/nusmods-export/3i37VpcRA72JhH5JGSMorzntUN1F
✅ Preview: https://nusmods-export-git-eliang-mpe-faq-and-fetch-fix-nusmodif-f71ef5.vercel.app

@codecov
Copy link

codecov bot commented Mar 3, 2021

Codecov Report

Merging #3261 (b351356) into master (b085737) will increase coverage by 0.01%.
The diff coverage is 0.00%.

Impacted file tree graph

@@            Coverage Diff             @@
##           master    #3261      +/-   ##
==========================================
+ Coverage   52.79%   52.80%   +0.01%     
==========================================
  Files         270      270              
  Lines        5720     5717       -3     
  Branches     1319     1320       +1     
==========================================
- Hits         3020     3019       -1     
+ Misses       2700     2698       -2     
Impacted Files Coverage Δ
website/src/apis/mpe.ts 0.00% <0.00%> (ø)
website/src/views/mpe/MpeContainer.tsx 0.00% <ø> (ø)
website/src/views/mpe/form/MpeFormContainer.tsx 0.00% <0.00%> (ø)
website/src/views/timetable/Timetable.tsx 93.54% <0.00%> (-3.23%) ⬇️

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update b085737...b351356. Read the comment docs.

@nusmods-deploy-bot
Copy link

nusmods-deploy-bot bot commented Mar 3, 2021

@taneliang
Copy link
Member Author

Verified to work:

Original crash repro steps:

  1. Add MA2002
  2. Reload
  3. Observe crash as MA2002.json doesn't exist in our modules

@taneliang taneliang merged commit b46cc61 into master Mar 3, 2021
@taneliang taneliang deleted the eliang/mpe-faq-and-fetch-fix branch March 3, 2021 14:23
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant