Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Gate MPE navtab behind enableMpe and flip enableMpe to false #3248

Merged
merged 3 commits into from
Feb 27, 2021

Conversation

taneliang
Copy link
Member

Context

#3035. Fix nits.

@vercel
Copy link

vercel bot commented Feb 27, 2021

This pull request is being automatically deployed with Vercel (learn more).
To see the status of your deployments, click below or on the icon next to each commit.

nusmods-website – ./website

🔍 Inspect: https://vercel.com/nusmodifications/nusmods-website/37ZsYXEDwwVhMQVBkPjKXuRoMSbD
✅ Preview: https://nusmods-website-git-eliang-mpe-gate-nusmodifications.vercel.app

nusmods-export – ./export

🔍 Inspect: https://vercel.com/nusmodifications/nusmods-export/9BforSXqUuvPygF4yWivaCFAKH3K
✅ Preview: https://nusmods-export-git-eliang-mpe-gate-nusmodifications.vercel.app

@codecov
Copy link

codecov bot commented Feb 27, 2021

Codecov Report

Merging #3248 (f7ec1ea) into master (759b4ef) will decrease coverage by 0.05%.
The diff coverage is 66.66%.

Impacted file tree graph

@@            Coverage Diff             @@
##           master    #3248      +/-   ##
==========================================
- Coverage   52.80%   52.75%   -0.06%     
==========================================
  Files         270      270              
  Lines        5713     5715       +2     
  Branches     1316     1318       +2     
==========================================
- Hits         3017     3015       -2     
- Misses       2696     2700       +4     
Impacted Files Coverage Δ
...rc/views/components/notfications/Announcements.tsx 57.14% <ø> (-21.43%) ⬇️
website/src/views/layout/Navtabs.tsx 90.00% <50.00%> (-10.00%) ⬇️
website/src/featureFlags.ts 100.00% <100.00%> (ø)

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 759b4ef...f7ec1ea. Read the comment docs.

@nusmods-deploy-bot
Copy link

@taneliang taneliang merged commit 2377c03 into master Feb 27, 2021
@taneliang taneliang deleted the eliang/mpe-gate branch February 27, 2021 09:29
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant