[AY1920S1-CS2113T-W13-4] DIYeats #19
Conversation
ivandika3
changed the title
There was a problem hiding this comment.
Take care of your header comments.
- Many classes/non-trivial methods don't have header comments.
- almost all of those present violate the coding standards.
You need to rethink a bit in terms of SLAP. I can see many SLAP violations across the codebase.
Exceptions need to be more granular.
It is good that you have started off on the tests, but you need to write more tests to cover each feature. easiest to write tests as and when you update code for your features.
src/main/java/duke/Main.java
Outdated
| } else { | ||
| ui.showWelcomeBack(user); | ||
| } | ||
| while (user.getIsSetup() == false) { //setup user profile if it's empty |
There was a problem hiding this comment.
you can improve SLAP in this method
src/main/java/duke/Main.java
Outdated
| } | ||
| } | ||
|
|
||
|
|
There was a problem hiding this comment.
While it is good to have vertical spacing, unnecessary vertical space is not good!
|
|
||
| /** | ||
| * This class file defines all the filepaths that will be used in the storage component. | ||
| * @author Chua Zong Wei |
There was a problem hiding this comment.
You can remove the @author tag. We can identify your commits via VCS
| */ | ||
| public class FilePaths { | ||
| public static final String sep = System.getProperty("file.separator"); | ||
| public static final File DATA_FILE = new File("src" + sep + "main" + sep + "java" + sep + "duke" |
There was a problem hiding this comment.
are you violating the naming convention for similar things?
| public static final File DATA_FILE = new File("src" + sep + "main" + sep + "java" + sep + "duke" | ||
| + sep + "Data" + sep + "duke.txt"); | ||
| public static final File DEFAULTS_FILE = new File("src" + sep + "main" + sep + "java" + sep + "duke" | ||
| + sep + "Data" + sep + "defaultItems.txt"); |
There was a problem hiding this comment.
You should probably use a config file to specify the paths; makes it much elegant
src/test/java/DukeTest.java
Outdated
| } | ||
|
|
||
| @Test | ||
| public void dummyTest2() { |
There was a problem hiding this comment.
you should move past dummy tests.
| Command c; | ||
| Parser parser = new Parser(autocorrect); | ||
| try { | ||
| c = parser.parse("add burger /calorie 100 /sodium 100 /fats 100"); |
There was a problem hiding this comment.
certain things can be moved to setup and teardown methods. checkout @before and @after annotations in Junit
| } catch (DukeException e) { | ||
| System.out.println("Error"); | ||
| } | ||
| autocorrect.setWord("calorei"); |
There was a problem hiding this comment.
you should be testing the method that is called within execute to unit test this.
| package duke.logic.parsers; | ||
|
|
||
| import duke.logic.autocorrect.Autocorrect; | ||
| import duke.logic.commands.*; |
There was a problem hiding this comment.
don't import using *; import classes that are necessary specifically
| import static org.junit.jupiter.api.Assertions.*; | ||
|
|
||
| public class UserTest { | ||
| private User user = new User("Foo Chi Hen", 22, 100, Gender.MALE, 0, true); |
There was a problem hiding this comment.
you may want to exclude personal data from public repositories. the choice, however, is completely yours.
…anager # Conflicts: # src/main/java/duke/Data/meals.json # src/main/java/duke/Data/user.json # src/main/java/duke/logic/parsers/AddDefaultValueCommandParser.java # src/main/java/duke/model/Item.java # src/main/java/duke/model/meal/MealList.java # src/main/java/duke/storage/Load.java
Changed user setup to one line as per requested. Changed code accordi…
added user setup junit test
…anager # Conflicts: # src/main/java/DIYeats/Data/meals.json # src/main/java/DIYeats/logic/commands/UserSetup.java # src/main/java/DIYeats/model/user/User.java # src/main/java/duke/Data/user.json # src/main/java/duke/commons/file/FilePathNames.java # src/test/java/DIYeats/logic/command/UserSetupTest.java
…-manager Exercise & weight manager
Resolve bug where date is not included and add some exception
# Conflicts: # DIYeats/Data/meals.json
update the autocorrect and help files
@koushireo
@Fractalisk
@HashirZahir