-
Notifications
You must be signed in to change notification settings - Fork 362
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[randallnhr] iP #389
Open
randallnhr
wants to merge
41
commits into
nus-cs2103-AY2223S2:master
Choose a base branch
from
randallnhr:master
base: master
Could not load branches
Branch not found: {{ refName }}
Loading
Could not load tags
Nothing to show
Loading
Are you sure you want to change the base?
Some commits from the old base branch may be removed from the timeline,
and old review comments may become outdated.
Open
[randallnhr] iP #389
Commits on Jul 31, 2022
-
Configuration menu - View commit details
-
Copy full SHA for 556af3f - Browse repository at this point
Copy the full SHA 556af3fView commit details
Commits on Jan 16, 2023
-
Configuration menu - View commit details
-
Copy full SHA for d931af6 - Browse repository at this point
Copy the full SHA d931af6View commit details -
Configuration menu - View commit details
-
Copy full SHA for 34904a0 - Browse repository at this point
Copy the full SHA 34904a0View commit details -
Configuration menu - View commit details
-
Copy full SHA for 4e12dad - Browse repository at this point
Copy the full SHA 4e12dadView commit details
Commits on Jan 18, 2023
-
Configuration menu - View commit details
-
Copy full SHA for 510ffff - Browse repository at this point
Copy the full SHA 510ffffView commit details
Commits on Jan 19, 2023
-
Configuration menu - View commit details
-
Copy full SHA for 927000e - Browse repository at this point
Copy the full SHA 927000eView commit details
Commits on Jan 20, 2023
-
Configuration menu - View commit details
-
Copy full SHA for 7315848 - Browse repository at this point
Copy the full SHA 7315848View commit details -
Configuration menu - View commit details
-
Copy full SHA for 149e1d0 - Browse repository at this point
Copy the full SHA 149e1d0View commit details -
Configuration menu - View commit details
-
Copy full SHA for 357e5f7 - Browse repository at this point
Copy the full SHA 357e5f7View commit details
Commits on Feb 3, 2023
-
Configuration menu - View commit details
-
Copy full SHA for c2c6903 - Browse repository at this point
Copy the full SHA c2c6903View commit details
Commits on Feb 4, 2023
-
Configuration menu - View commit details
-
Copy full SHA for 231ec2e - Browse repository at this point
Copy the full SHA 231ec2eView commit details -
Configuration menu - View commit details
-
Copy full SHA for 4614698 - Browse repository at this point
Copy the full SHA 4614698View commit details -
Configuration menu - View commit details
-
Copy full SHA for dbb7cbf - Browse repository at this point
Copy the full SHA dbb7cbfView commit details -
Configuration menu - View commit details
-
Copy full SHA for df38bca - Browse repository at this point
Copy the full SHA df38bcaView commit details -
Configuration menu - View commit details
-
Copy full SHA for 5c0e7b1 - Browse repository at this point
Copy the full SHA 5c0e7b1View commit details
Commits on Feb 5, 2023
-
Configuration menu - View commit details
-
Copy full SHA for 674f297 - Browse repository at this point
Copy the full SHA 674f297View commit details -
Configuration menu - View commit details
-
Copy full SHA for c894cbf - Browse repository at this point
Copy the full SHA c894cbfView commit details -
Configuration menu - View commit details
-
Copy full SHA for 2e673f7 - Browse repository at this point
Copy the full SHA 2e673f7View commit details -
Configuration menu - View commit details
-
Copy full SHA for 359765a - Browse repository at this point
Copy the full SHA 359765aView commit details -
Configuration menu - View commit details
-
Copy full SHA for 224fa30 - Browse repository at this point
Copy the full SHA 224fa30View commit details -
Configuration menu - View commit details
-
Copy full SHA for 24d5209 - Browse repository at this point
Copy the full SHA 24d5209View commit details -
Configuration menu - View commit details
-
Copy full SHA for 74266a2 - Browse repository at this point
Copy the full SHA 74266a2View commit details -
Configuration menu - View commit details
-
Copy full SHA for 56f1dc5 - Browse repository at this point
Copy the full SHA 56f1dc5View commit details -
Configuration menu - View commit details
-
Copy full SHA for 25c6740 - Browse repository at this point
Copy the full SHA 25c6740View commit details
Commits on Feb 11, 2023
-
Set up JavaFX and link Duke class to GUI. Add MainWindow.java as controller for as main GUI. Add DialogBox.java as controller for DialogBox in GUI. Add MainWindow.fxml and DialogBox.fxml for GUI layout and interaction
Configuration menu - View commit details
-
Copy full SHA for 1318085 - Browse repository at this point
Copy the full SHA 1318085View commit details
Commits on Feb 12, 2023
-
Set up JavaFX and link Duke class to GUI. Add MainWindow.java as controller for as main GUI. Add DialogBox.java as controller for DialogBox in GUI. Add MainWindow.fxml and DialogBox.fxml for GUI layout and interaction
Configuration menu - View commit details
-
Copy full SHA for 31a8483 - Browse repository at this point
Copy the full SHA 31a8483View commit details -
Configuration menu - View commit details
-
Copy full SHA for c0d137a - Browse repository at this point
Copy the full SHA c0d137aView commit details -
Assertions make it easier to ensure that certain variables/ methods are behaving as expected. By using assertions, we can make debugging easier as assumptions are ensured.
Configuration menu - View commit details
-
Copy full SHA for caacaec - Browse repository at this point
Copy the full SHA caacaecView commit details -
Merge pull request #2 from randallnhr/branch-A-Assertions
Add assertions
Configuration menu - View commit details
-
Copy full SHA for 0af8473 - Browse repository at this point
Copy the full SHA 0af8473View commit details -
There are several methods that use complicated expressions. `mark`, `unmark`, `deadline` and `delete` methods in Parser class has 2 checks in an if condition. Abstracted the checks to 2 variables to enhance readability. `event` method in the Parser class has 3 checks in the if condition. Abstracted the checks to 3 variables to enhance readability. As a step forward, let's abstract complicated checks in the conditions.
Configuration menu - View commit details
-
Copy full SHA for 47ec878 - Browse repository at this point
Copy the full SHA 47ec878View commit details -
Configuration menu - View commit details
-
Copy full SHA for 8794559 - Browse repository at this point
Copy the full SHA 8794559View commit details -
Merge pull request #3 from randallnhr/branch-A-CodeQuality
Branch a code quality
Configuration menu - View commit details
-
Copy full SHA for c21cf25 - Browse repository at this point
Copy the full SHA c21cf25View commit details
Commits on Feb 14, 2023
-
Allow users to change the /by date of deadline tasks and /from, /to of event tasks.
Configuration menu - View commit details
-
Copy full SHA for 8539e7e - Browse repository at this point
Copy the full SHA 8539e7eView commit details -
Configuration menu - View commit details
-
Copy full SHA for d962643 - Browse repository at this point
Copy the full SHA d962643View commit details
Commits on Feb 16, 2023
-
Configuration menu - View commit details
-
Copy full SHA for 47632b4 - Browse repository at this point
Copy the full SHA 47632b4View commit details -
Configuration menu - View commit details
-
Copy full SHA for 0f35873 - Browse repository at this point
Copy the full SHA 0f35873View commit details -
Configuration menu - View commit details
-
Copy full SHA for 1c91d33 - Browse repository at this point
Copy the full SHA 1c91d33View commit details -
Configuration menu - View commit details
-
Copy full SHA for 919e432 - Browse repository at this point
Copy the full SHA 919e432View commit details -
Configuration menu - View commit details
-
Copy full SHA for 9a5d484 - Browse repository at this point
Copy the full SHA 9a5d484View commit details
Commits on Feb 17, 2023
-
Configuration menu - View commit details
-
Copy full SHA for a70e173 - Browse repository at this point
Copy the full SHA a70e173View commit details -
Configuration menu - View commit details
-
Copy full SHA for 0c185b1 - Browse repository at this point
Copy the full SHA 0c185b1View commit details
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.