-
Notifications
You must be signed in to change notification settings - Fork 362
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[Lin Weilin] iP #368
base: master
Are you sure you want to change the base?
[Lin Weilin] iP #368
Commits on Jul 31, 2022
-
Configuration menu - View commit details
-
Copy full SHA for 556af3f - Browse repository at this point
Copy the full SHA 556af3fView commit details
Commits on Jan 24, 2023
-
Configuration menu - View commit details
-
Copy full SHA for da98b2d - Browse repository at this point
Copy the full SHA da98b2dView commit details
Commits on Jan 25, 2023
-
Configuration menu - View commit details
-
Copy full SHA for f1267e3 - Browse repository at this point
Copy the full SHA f1267e3View commit details -
Configuration menu - View commit details
-
Copy full SHA for 6dadf28 - Browse repository at this point
Copy the full SHA 6dadf28View commit details -
Configuration menu - View commit details
-
Copy full SHA for 464bf09 - Browse repository at this point
Copy the full SHA 464bf09View commit details -
Configuration menu - View commit details
-
Copy full SHA for a03b4ff - Browse repository at this point
Copy the full SHA a03b4ffView commit details -
Configuration menu - View commit details
-
Copy full SHA for 93bcdaa - Browse repository at this point
Copy the full SHA 93bcdaaView commit details -
Configuration menu - View commit details
-
Copy full SHA for 4e46cba - Browse repository at this point
Copy the full SHA 4e46cbaView commit details
Commits on Jan 31, 2023
-
Configuration menu - View commit details
-
Copy full SHA for 2a0d657 - Browse repository at this point
Copy the full SHA 2a0d657View commit details
Commits on Feb 1, 2023
-
Configuration menu - View commit details
-
Copy full SHA for 38c70c8 - Browse repository at this point
Copy the full SHA 38c70c8View commit details
Commits on Feb 7, 2023
-
Configuration menu - View commit details
-
Copy full SHA for 5fa18f0 - Browse repository at this point
Copy the full SHA 5fa18f0View commit details -
Configuration menu - View commit details
-
Copy full SHA for fede33d - Browse repository at this point
Copy the full SHA fede33dView commit details -
Configuration menu - View commit details
-
Copy full SHA for 0875429 - Browse repository at this point
Copy the full SHA 0875429View commit details -
Configuration menu - View commit details
-
Copy full SHA for 446b67b - Browse repository at this point
Copy the full SHA 446b67bView commit details -
Configuration menu - View commit details
-
Copy full SHA for cc040c0 - Browse repository at this point
Copy the full SHA cc040c0View commit details -
Configuration menu - View commit details
-
Copy full SHA for ac9f6fa - Browse repository at this point
Copy the full SHA ac9f6faView commit details
Commits on Feb 13, 2023
-
Configuration menu - View commit details
-
Copy full SHA for e209948 - Browse repository at this point
Copy the full SHA e209948View commit details -
Configuration menu - View commit details
-
Copy full SHA for d64c6e2 - Browse repository at this point
Copy the full SHA d64c6e2View commit details -
Configuration menu - View commit details
-
Copy full SHA for c837839 - Browse repository at this point
Copy the full SHA c837839View commit details -
Configuration menu - View commit details
-
Copy full SHA for 7b1c7c8 - Browse repository at this point
Copy the full SHA 7b1c7c8View commit details -
Configuration menu - View commit details
-
Copy full SHA for 6cfe59e - Browse repository at this point
Copy the full SHA 6cfe59eView commit details -
Configuration menu - View commit details
-
Copy full SHA for 7dd4bf2 - Browse repository at this point
Copy the full SHA 7dd4bf2View commit details
Commits on Feb 14, 2023
-
Configuration menu - View commit details
-
Copy full SHA for efd490e - Browse repository at this point
Copy the full SHA efd490eView commit details -
Configuration menu - View commit details
-
Copy full SHA for 4dd86d6 - Browse repository at this point
Copy the full SHA 4dd86d6View commit details
Commits on Feb 15, 2023
-
Merge pull request #2 from weilin1202/branch-A-Assertions
Add A-Assertions
Configuration menu - View commit details
-
Copy full SHA for 63a7e15 - Browse repository at this point
Copy the full SHA 63a7e15View commit details -
Configuration menu - View commit details
-
Copy full SHA for a1e008c - Browse repository at this point
Copy the full SHA a1e008cView commit details -
Merge pull request #3 from weilin1202/branch-A-CodeQuality
Parser performCommand: Code quality has not been achieved because method is too long and OOP is not fully achieved PerformCommand is supposed to handle the general processing of command, checking the performing comman shall be done in separate classes for each different cases. Created several classes in Parser to handle different types of commands to make the code quality better, ensuring methods are not too long and as well as to make full use of OOP.
Configuration menu - View commit details
-
Copy full SHA for 0aa85b9 - Browse repository at this point
Copy the full SHA 0aa85b9View commit details -
Configuration menu - View commit details
-
Copy full SHA for 9d0d3ad - Browse repository at this point
Copy the full SHA 9d0d3adView commit details -
Configuration menu - View commit details
-
Copy full SHA for 0e677a9 - Browse repository at this point
Copy the full SHA 0e677a9View commit details -
Storage class: create file and is stored locally with a specific cust…
…omised path for my hard disk The user using Duke might not have same file path in local hard disk The file path has thus been changed to ./data/duke.txt which makes it more general than the previous iteration Let's create a new text file in ./data/duke.txt instead of C:\Users\linwe\Documents\taskSaved.txt!
Configuration menu - View commit details
-
Copy full SHA for 8dd634a - Browse repository at this point
Copy the full SHA 8dd634aView commit details -
Classes that handle separate commands in Parser folder: The checking …
…of the validity of inputs are not robust Checking not being robust will result in Duke mis-intepereting an input as valid when it is not, thereby causes execption being thrown without catching Included more robust checking to ensure the inputs are in correct format, before a task object is created Let's check the inputs by trying throwing and catching exception when inputs are incorrect!
Configuration menu - View commit details
-
Copy full SHA for 30fe297 - Browse repository at this point
Copy the full SHA 30fe297View commit details -
Cannot detect duplicates in the addition of tasks
Same tasks can be added multiple times Add C-DetectDuplicates It is more user friendly so that users would not accidentally add same tasks into the task list. Let's * Check whether there are existing same task in task list as the task that user has keyed in * Include the equals function in task to check whether two tasks are the same or not
Configuration menu - View commit details
-
Copy full SHA for 08739db - Browse repository at this point
Copy the full SHA 08739dbView commit details -
Moved the printing of String from Parser class to Ui class as Ui settles
the interaction with User and not the parser
Configuration menu - View commit details
-
Copy full SHA for c3c9b23 - Browse repository at this point
Copy the full SHA c3c9b23View commit details -
Resolved the bugs discovered in Storage class after testing
and improved implementation of the different tasks
Configuration menu - View commit details
-
Copy full SHA for fc08d66 - Browse repository at this point
Copy the full SHA fc08d66View commit details -
Configuration menu - View commit details
-
Copy full SHA for 05d2448 - Browse repository at this point
Copy the full SHA 05d2448View commit details -
Configuration menu - View commit details
-
Copy full SHA for 86e1c0b - Browse repository at this point
Copy the full SHA 86e1c0bView commit details
Commits on Feb 16, 2023
-
Add the javadocs for newly implemented methods and classes
Improve code style and quality and passed checkstyle
Configuration menu - View commit details
-
Copy full SHA for f499929 - Browse repository at this point
Copy the full SHA f499929View commit details -
Configuration menu - View commit details
-
Copy full SHA for 098bc19 - Browse repository at this point
Copy the full SHA 098bc19View commit details -
Configuration menu - View commit details
-
Copy full SHA for 017ad98 - Browse repository at this point
Copy the full SHA 017ad98View commit details -
Configuration menu - View commit details
-
Copy full SHA for 4bad7ab - Browse repository at this point
Copy the full SHA 4bad7abView commit details
Commits on Feb 17, 2023
-
Configuration menu - View commit details
-
Copy full SHA for 4eb813f - Browse repository at this point
Copy the full SHA 4eb813fView commit details -
Configuration menu - View commit details
-
Copy full SHA for d826e7d - Browse repository at this point
Copy the full SHA d826e7dView commit details -
Configuration menu - View commit details
-
Copy full SHA for e245b55 - Browse repository at this point
Copy the full SHA e245b55View commit details -
Configuration menu - View commit details
-
Copy full SHA for 04c97d2 - Browse repository at this point
Copy the full SHA 04c97d2View commit details -
Configuration menu - View commit details
-
Copy full SHA for 58d0416 - Browse repository at this point
Copy the full SHA 58d0416View commit details -
Configuration menu - View commit details
-
Copy full SHA for 071a988 - Browse repository at this point
Copy the full SHA 071a988View commit details -
Configuration menu - View commit details
-
Copy full SHA for 5e9baa0 - Browse repository at this point
Copy the full SHA 5e9baa0View commit details -
Configuration menu - View commit details
-
Copy full SHA for e3827ec - Browse repository at this point
Copy the full SHA e3827ecView commit details -
Updated the date checking when handling deadline and event timeline
Entering dates before the current date is not allowed For event, start date cannot be after end date
Configuration menu - View commit details
-
Copy full SHA for 04b33d7 - Browse repository at this point
Copy the full SHA 04b33d7View commit details -
Configuration menu - View commit details
-
Copy full SHA for 3a0362a - Browse repository at this point
Copy the full SHA 3a0362aView commit details -
Configuration menu - View commit details
-
Copy full SHA for cad8c22 - Browse repository at this point
Copy the full SHA cad8c22View commit details -
Improved implementation of checking input for adding of tasks.
Settle case when input is missing or is filled with spaces
Configuration menu - View commit details
-
Copy full SHA for 92764d1 - Browse repository at this point
Copy the full SHA 92764d1View commit details -
Configuration menu - View commit details
-
Copy full SHA for 8df56e7 - Browse repository at this point
Copy the full SHA 8df56e7View commit details -
Configuration menu - View commit details
-
Copy full SHA for f41a5fe - Browse repository at this point
Copy the full SHA f41a5feView commit details -
Configuration menu - View commit details
-
Copy full SHA for df0211b - Browse repository at this point
Copy the full SHA df0211bView commit details