[T7][F11-C4] #96

praveer922 · 2016-10-06T16:54:34Z

No description provided.

nus-se-pr-bot · 2016-10-06T16:54:57Z

Hi @praveer922, your pull request title is invalid. It should be in the format of [Activity ID][Team ID] Your name, where [Activity Id] has no dashes or spaces (e.g. [T2A3] stands for Tutorial 2 Activity 3) and [Team ID] has one dash only and no spaces (e.g. [W14-A2] means Wednesday 2pm (14 hrs), Phase A, Team 2). Please follow the instructions given strictly and edit your title for reprocessing.

Submit only one activity per pull request (unless otherwise stated in instructions) and do remember to create your branches from the commit where the master branch is pointing at so that each PR you submit only consist of commits meant for the activity.

Note: this comment is posted by a bot. If you believe this is done in error, please create an issue at cs2103-pr-bot and add a link to this PR.

cmkumar87

Partially reviewed.

cmkumar87 · 2016-10-08T07:28:40Z

docs/DeveloperGuide.md

+`* * *` | user | find a task by name | search for a task  without having to go through the entire list
+`* * *` | user | edit a task and its particulars | update instantly if there are any changes in the task
+`* *` | user | view the tasks | take a quick glance or have my tasks presented according to my needs and preference
+`* *` | user | set recurring tasks | save the hassle of contstantly updating my regular activities


feature spec not clear. I think you mean 'Set recurring tasks as Favourites'

cmkumar87 · 2016-10-08T07:29:57Z

docs/DeveloperGuide.md

-`*` | user with many persons in the address book | sort persons by name | locate a person easily
+`* * *` | user | add new task | find out  tasks are urgently due
+`* * *` | user | set deadlines | be reminded of my due dates for my respective tasks
+`* * *` | user | delete a task | remove entries that are completed


You may simply want to mark tasks that were completed instead of deleting them. You could also add a low priority enhancement that allows you to view the completed tasks datewise.

cmkumar87 · 2016-10-08T07:30:54Z

docs/DeveloperGuide.md

-`* *` | user | hide [private contact details](#private-contact-detail) by default | minimize chance of someone else seeing them by accident
-`*` | user with many persons in the address book | sort persons by name | locate a person easily
+`* * *` | user | add new task | find out  tasks are urgently due
+`* * *` | user | set deadlines | be reminded of my due dates for my respective tasks


why is deadlines a separate feature? User can optionally add a deadline when creating a task.

cmkumar87 · 2016-10-08T07:33:38Z

docs/DeveloperGuide.md

+`* * *` | user | delete a task | remove entries that are completed
+`* * *` | user | find a task by name | search for a task  without having to go through the entire list
+`* * *` | user | edit a task and its particulars | update instantly if there are any changes in the task
+`* *` | user | view the tasks | take a quick glance or have my tasks presented according to my needs and preference


narrow the scope of this feature. for e.g., view tasks that are due today or the next 3 days or by priority if the user is setting one. Right now you seem to want to cover everything which is too much for the first few phases of development.

cmkumar87 · 2016-10-08T07:35:58Z

docs/DeveloperGuide.md

+
+**Extensions**
+
+1a. Required information for task missing


Have you identified what are the mandatory fields to add a task? You should know this by now.

cmkumar87 · 2016-10-08T07:36:33Z

docs/DeveloperGuide.md

+
+**MSS**
+
+1. User requests to view tsks for specific time period


fix typo. tsks --> tasks.
Be more specific about what do you mean by time period: by day?, hour? Do you need a from and to time or only the end time which assumes the start time as 'now'.
User can also find a task using the 'Find' feature and then ask the task to be deleted.

cmkumar87 · 2016-10-08T07:42:41Z

docs/DeveloperGuide.md

+>Use case ends
+
+3a. Given index is invalid
+>3b1. Task manager shows error message <br>


Not clear. What do you mean by index? Neither the user story nor MSS mention any index!

cmkumar87 · 2016-10-08T07:43:23Z

docs/DeveloperGuide.md

+>3b1. Task manager shows error message <br>
+Use case resumes at step 2
+
+4a. If deleting a recurring task


This is an advanced feature. Don't push it in the basic delete.

# Conflicts: # src/test/java/seedu/address/testutil/TestPerson.java

…/main into undocommand # Conflicts: # src/main/java/seedu/dailyplanner/logic/parser/Parser.java

…016-F11-C4/main

# Conflicts: # src/main/java/seedu/dailyplanner/logic/parser/Parser.java

nus-se-pr-bot added the FormatCheckRequested label Oct 6, 2016

cmkumar87 reviewed Oct 8, 2016

View reviewed changes

cmkumar87 added the Reviewed label Oct 11, 2016

praveer922 changed the title ~~[T7] [F11-C4]~~ [T7][F11-C4] Oct 14, 2016

nus-se-pr-bot removed the FormatCheckRequested label Oct 14, 2016

nus-se-pr-bot assigned cmkumar87 Oct 14, 2016

praveer922 and others added 23 commits October 21, 2016 21:03

Implement edit command

2131dba

Implement Complete Command

9f4b698

Refactor test case with setter methods for task object

d4e1086

Refactor Show Command

9270a04

Merge branch 'master' of https://github.com/CS2103AUG2016-F11-C4/main

698f358

# Conflicts: # src/test/java/seedu/address/testutil/TestPerson.java

Edit class path

9acec7e

Edit PersonBuilder and TestPerson

4068cac

Refactor Complete Command

86968f3

Add command format validation

8ae38b0

Store history of commands in model manager

dfc67cc

Update collate folder

f1f7921

Update collate folder

56f91ab

Fix validation of command format

9917db5

Merge branch 'undoCommand' of https://github.com/CS2103AUG2016-F11-C4…

f21c35c

…/main into undocommand # Conflicts: # src/main/java/seedu/dailyplanner/logic/parser/Parser.java

Refactor test code

b9306ca

Implement EditCommandTest

31da7ea

Fix add command format validation

849f765

Updated test in collated folder

d4e0515

Implement sorting

5221b51

Fix gradle dependencies and delete test case

d00451d

Merge branch 'master' of https://github.com/CS2103AUG2016-F11-C4/main

c612e64

Refactor Complete Command

2f7646f

Merge branch 'master' of https://github.com/CS2103AUG2016-F11-C4/main

3e40273

rainy-windy and others added 30 commits November 8, 2016 10:37

Edit User guide and recollated

09afcc1

Update DeveloperGuide.md

0ce1724

Update A0146749N.md

94984fb

Update DeveloperGuide.md

842bc52

Sample test data

7496dd9

TestScript

2382f20

Refactor DateTime class

c3d7d71

Refactor Date

cdd4eee

Refractor Time

6b423ff

Make setters and getters for Time and Date

9cfecca

Update test script

daefd18

call clashtask only once

0223393

Refactor Parser

4b94b52

Merge branch 'master' of https://github.com/CS2103AUG2016-F11-C4/main

47aeb08

Refactor Parser

543f1ba

Refactor parser

d7089e7

natty wrapper abstraction

3108317

SLAP prepareAdd and prepareEdit of Parser

f6c402a

Merge branches 'master' and 'master' of https://github.com/CS2103AUG2…

5713bee

…016-F11-C4/main

abstraction in several classes

b76c5cc

Merge branch 'master' of https://github.com/CS2103AUG2016-F11-C4/main

d6be7e6

# Conflicts: # src/main/java/seedu/dailyplanner/logic/parser/Parser.java

Final commit

d2b3fef

Fix unpin test bug

ed0bffe

Finalising collate

3f1d50d

Edit testscript

720b1d5

Update TestScript.md

89b4585

Update TestScript.md

0f96cac

Revised collate

2b0d541

Fix add multiple categories bug

3e9d233

Fix remove field bug

26a6412

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

[T7][F11-C4] #96

[T7][F11-C4] #96

praveer922 commented Oct 6, 2016

nus-se-pr-bot commented Oct 6, 2016

cmkumar87 left a comment

cmkumar87 Oct 8, 2016

cmkumar87 Oct 8, 2016

cmkumar87 Oct 8, 2016

cmkumar87 Oct 8, 2016

cmkumar87 Oct 8, 2016

cmkumar87 Oct 8, 2016 •

edited

Loading

cmkumar87 Oct 8, 2016

cmkumar87 Oct 8, 2016


		MSS

		1. User requests to view tsks for specific time period

[T7][F11-C4] #96

Are you sure you want to change the base?

[T7][F11-C4] #96

Conversation

praveer922 commented Oct 6, 2016

nus-se-pr-bot commented Oct 6, 2016

cmkumar87 left a comment

Choose a reason for hiding this comment

cmkumar87 Oct 8, 2016

Choose a reason for hiding this comment

cmkumar87 Oct 8, 2016

Choose a reason for hiding this comment

cmkumar87 Oct 8, 2016

Choose a reason for hiding this comment

cmkumar87 Oct 8, 2016

Choose a reason for hiding this comment

cmkumar87 Oct 8, 2016

Choose a reason for hiding this comment

cmkumar87 Oct 8, 2016 • edited Loading

Choose a reason for hiding this comment

cmkumar87 Oct 8, 2016

Choose a reason for hiding this comment

cmkumar87 Oct 8, 2016

Choose a reason for hiding this comment

cmkumar87 Oct 8, 2016 •

edited

Loading