-
Notifications
You must be signed in to change notification settings - Fork 109
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[T7][T15-C4] #43
base: master
Are you sure you want to change the base?
[T7][T15-C4] #43
Conversation
jamesBranch v0.1
…ch should be changed to properly implement CRUD for tasks.
V0.1 completed. A bit janky.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Some comments added. Please review them and close the PR.
@@ -1,7 +1,7 @@ | |||
<?xml version="1.0" encoding="UTF-8"?> | |||
<projectDescription> | |||
<name>addressbook-level4</name> | |||
<comment>Project addressbook-level4 created by Buildship.</comment> | |||
<name>main</name> |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Add your project name here.
<img src="images/YouLiang.jpg" width="150"><br> | ||
Role: Developer <br> | ||
Responsibilities: UI | ||
Responsibilities: Documentation, Testing, Deliverables and Deadlines |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
You can also mention the packages each person is in-charge of in this file. If not, I hope you have already divided it and have an understanding of the same among yourself.
`* *` | user | auto-complete certain tasks | save time instead of having to type out the whole command. | ||
`*` | user | manipulate the schedule with a mouse | save time manipulating the calendar directly as opposed to having to go back to the CLI and type in more command rescheduling events (e.g. drag-drop vs. retyping event details) | ||
`*` | user | view list or calendar in a pop out window | look at it more easily while working on other items. | ||
`*` | user | have a nice GUI | have an easier time manipulating the information and let the program be more pleasing to my eyes. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Sounds more like a non-functional requirement. Try adding more specific details about the feature.
`* *` | user | specify the location to place the data storage | do things with it, like sync it to my Dropbox. | ||
`* *` | user | bring up the program with a hotkey | pull it up quickly and conveniently when I need to add a task. | ||
`* *` | user | schedule multiple time blocks with one task | schedule tasks or events that have multiple and different deadlines or dates. | ||
`* *` | user | auto-complete certain tasks | save time instead of having to type out the whole command. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Define certain
? Mention the type of tasks (deadlines, events or floating tasks) you wish to to auto-complete.
`* * *` | user | receive reminders for upcoming tasks | don't forget about tasks | ||
`* *` | user | add tasks through plain English | type more naturally than having to write in commands and flags. | ||
`* *` | user | view tasks in a calendar format | figure out what events/tasks I have upcoming more easily. | ||
`* *` | user | specify the location to place the data storage | do things with it, like sync it to my Dropbox. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Ah, this is a must-have feature. It needs to be assigned higher priority.
4. Should favor DOS style commands over Unix-style commands. | ||
1. Program should load within 5 seconds | ||
2. Storage file should be limited to 100MB default (can be changed by user) | ||
3. Should work on any mainstream OS |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Mention the maintstream OS
you are aiming for.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
We defined the term 'mainstream OS' in the glossary; is that enough, or should we mention them specifically in the NFR?
4. Should hold up to 1000 tasks/events on the active task list at any time | ||
5. Comes with automated unit tests. | ||
6. Commands should be intuitive and easy to use. | ||
7. Interface is simple and easy to understand. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Can add simple and easy to understand
for who ? Beginner, Novice, Expert, Jim ?
4. Type the command in the command box and press <kbd>Enter</kbd> to execute it. <br> | ||
e.g. typing **`help`** and pressing <kbd>Enter</kbd> will open the help window. | ||
|
||
1. Download the latest '[insert program name here]' from the releases (../../../release) tab |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
'insert program name here'
😄
@@ -16,28 +16,28 @@ | |||
*/ | |||
public class AddressBook implements ReadOnlyAddressBook { |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Please rename AddressBook.
*/ | ||
public class Deadline { | ||
|
||
public static final String MESSAGE_DEADLINE_CONSTRAINTS = |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Is public
the best access modifier for MESSAGE_DEADLINE_CONSTRAINTS
? As a rule of thumb start all data members as private, and depending on their usage promote them to protected, and if absolutely necessary, to public.
@JamesHuangUC @mchen14 I have some general remarks:
|
updated guides according to feedback from mentor
…Murray branch. However, made new temp branch because will eventually go back to Murray branch once errors are discovered and it isnt the day before the deadline. Fixes #17
updated developer guide and other small changes
update jamesTempBranch
Added and updated sort command, user guide, ui
added undo test
added manual testing
update format of TestScript.md
renamed sample data
collated files
last minute refactoring
Ready for review