Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[W6.1f][F10-B2] Chen Huijia #873

Open
wants to merge 2 commits into
base: master
Choose a base branch
from
Open
Show file tree
Hide file tree
Changes from all commits
Commits
File filter

Filter by extension

Filter by extension

Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
3 changes: 2 additions & 1 deletion src/seedu/addressbook/commands/AddCommand.java
Original file line number Diff line number Diff line change
Expand Up @@ -66,5 +66,6 @@ public CommandResult execute() {
return new CommandResult(MESSAGE_DUPLICATE_PERSON);
}
}

@Override
public boolean isMutating() { return true; }
}
3 changes: 3 additions & 0 deletions src/seedu/addressbook/commands/ClearCommand.java
Original file line number Diff line number Diff line change
Expand Up @@ -16,4 +16,7 @@ public CommandResult execute() {
addressBook.clear();
return new CommandResult(MESSAGE_SUCCESS);
}

@Override
public boolean isMutating() { return true; }
}
5 changes: 5 additions & 0 deletions src/seedu/addressbook/commands/Command.java
Original file line number Diff line number Diff line change
Expand Up @@ -41,6 +41,11 @@ public static String getMessageForPersonListShownSummary(List<? extends ReadOnly
*/
public abstract CommandResult execute();

//this method is already an abstract method!
//another example of abstract method isMutating()

public abstract boolean isMutating();

/**
* Supplies the data the command will operate on.
*/
Expand Down
3 changes: 2 additions & 1 deletion src/seedu/addressbook/commands/DeleteCommand.java
Original file line number Diff line number Diff line change
Expand Up @@ -38,5 +38,6 @@ public CommandResult execute() {
return new CommandResult(Messages.MESSAGE_PERSON_NOT_IN_ADDRESSBOOK);
}
}

@Override
public boolean isMutating() { return true; }
}
3 changes: 2 additions & 1 deletion src/seedu/addressbook/commands/ExitCommand.java
Original file line number Diff line number Diff line change
Expand Up @@ -15,5 +15,6 @@ public class ExitCommand extends Command {
public CommandResult execute() {
return new CommandResult(MESSAGE_EXIT_ACKNOWEDGEMENT);
}

@Override
public boolean isMutating() { return false; }
Copy link

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Coding standard violation:exclamation: One or more of these problems noticed:

  1. extra/missing spaces
  2. brace style problem
  3. missing braces
  4. name doesn't follow naming convention
  5. line too long

}
3 changes: 2 additions & 1 deletion src/seedu/addressbook/commands/FindCommand.java
Original file line number Diff line number Diff line change
Expand Up @@ -52,5 +52,6 @@ private List<ReadOnlyPerson> getPersonsWithNameContainingAnyKeyword(Set<String>
}
return matchedPersons;
}

@Override
public boolean isMutating() { return false; }
}
3 changes: 3 additions & 0 deletions src/seedu/addressbook/commands/HelpCommand.java
Original file line number Diff line number Diff line change
Expand Up @@ -25,4 +25,7 @@ public class HelpCommand extends Command {
public CommandResult execute() {
return new CommandResult(MESSAGE_ALL_USAGES);
}

@Override
public boolean isMutating() { return false; }
}
3 changes: 3 additions & 0 deletions src/seedu/addressbook/commands/ListCommand.java
Original file line number Diff line number Diff line change
Expand Up @@ -22,4 +22,7 @@ public CommandResult execute() {
List<ReadOnlyPerson> allPersons = addressBook.getAllPersons().immutableListView();
return new CommandResult(getMessageForPersonListShownSummary(allPersons), allPersons);
}

@Override
public boolean isMutating() { return false; }
}
3 changes: 3 additions & 0 deletions src/seedu/addressbook/commands/ViewAllCommand.java
Original file line number Diff line number Diff line change
Expand Up @@ -37,4 +37,7 @@ public CommandResult execute() {
return new CommandResult(Messages.MESSAGE_INVALID_PERSON_DISPLAYED_INDEX);
}
}

@Override
public boolean isMutating() { return false; }
}
3 changes: 3 additions & 0 deletions src/seedu/addressbook/commands/ViewCommand.java
Original file line number Diff line number Diff line change
Expand Up @@ -38,4 +38,7 @@ public CommandResult execute() {
}
}

@Override
public boolean isMutating() { return false; }

}