Focus README on docker-compose; README fixups; reduce docker-compose dep #7
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
* README.md Move Docker Compose instructions to the top of the types of setup, and name it "Quick Start with Docker Compose". Fix bug in instructions to append to /etc/default/telegraf in the bare metal instructions (use sudo tee). Added instructions for verifying installation by checking that `nuodb_internal` and `nuodb` databases exist in influx. Changed Kubernetes section to say "coming soon". Fix header depth so that each of the Setup types are at the top level. Fix whitespace. * docker-compose.yml Reduce dependency from 3.7 to 3.3, seems to work just fine and is required for the versions of docker and docker-compose on Ubuntu.
jleslie85
approved these changes
Oct 23, 2020
mkysel
reviewed
Oct 26, 2020
README.md
Outdated
Comment on lines
+199
to
+201
| INFLUXURL=http://<hostinflux>:8086 | ||
| PYTHONPATH=/opt/nuocd/pylib | ||
| EOF |
There was a problem hiding this comment.
these three lines are now duplicated. Is that on purpose?
There was a problem hiding this comment.
No, good catch. Must have made an error when cleaning the changes up. I'll push a fix now.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
= README.md
Move Docker Compose instructions to the top of the types of setup, and
name it "Quick Start with Docker Compose".
Fix bug in instructions to append to /etc/default/telegraf in the bare
metal instructions (use sudo tee).
Added instructions for verifying installation by checking that
nuodb_internalandnuodbdatabases exist in influx.Changed Kubernetes section to say "coming soon".
Fix header depth so that each of the Setup types are at the top level.
Fix whitespace.
= docker-compose.yml
Reduce dependency from 3.7 to 3.3, seems to work just fine and is
required for the versions of docker and docker-compose on Ubuntu.