Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Use the public API of nuodb_mgmt #17

Merged
merged 1 commit into from
Nov 24, 2020
Merged

Use the public API of nuodb_mgmt #17

merged 1 commit into from
Nov 24, 2020

Conversation

mkysel
Copy link
Contributor

@mkysel mkysel commented Nov 24, 2020

internals are subject to change. Future releases of pynuoadmin will break nuocd. Use public functions only

butson
butson approved these changes Nov 24, 2020
View reviewed changes
Copy link
Contributor

@butson butson left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Didn't know the send_query_request existed or it didn't exist when I first wrote the functions.

@mkysel mkysel merged commit 9767b03 into master Nov 24, 2020
@mkysel mkysel deleted the mkysel/public-interface branch November 24, 2020 23:04
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@adriansuarez adriansuarez adriansuarez approved these changes

@butson butson butson approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@mkysel @adriansuarez @butson