-
-
Notifications
You must be signed in to change notification settings - Fork 282
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Fix retrieving composer binary path in SyntaxCheck #505
Fix retrieving composer binary path in SyntaxCheck #505
Conversation
Thanks! |
Any chance this patch has not been included on the Docker images?
|
$baseProjectPath = \dirname(__DIR__, 3); | ||
if (file_exists($baseProjectPath . DIRECTORY_SEPARATOR . 'vendor' . DIRECTORY_SEPARATOR . 'autoload.php')) { | ||
return $baseProjectPath; | ||
$composerBinaryFolder = DIRECTORY_SEPARATOR . 'vendor' . DIRECTORY_SEPARATOR . 'bin'; |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
vendor/bin
shouldn't be hardcoded, it should respect composer's config.bin-dir
setting.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
https://github.com/nunomaduro/phpinsights/pull/505/files#R44
Maybe use composer exec -- <bin>
here to ensure parallel-lint is in the $PATH and let composer handle finding the bin dir?
As @tarlepp indicate in #504, when we install phpinsights through bamarni composer plugin, the SyntaxCheck Insight is unable to find the correct path for using parallel-lint.
This PR should fix that