Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[Improvement] Reduce set_error_handler call #405

Merged
merged 1 commit into from
May 10, 2020

Conversation

Jibbarth
Copy link
Collaborator

@Jibbarth Jibbarth commented May 9, 2020

Q A
Bug fix? no
New feature? no
Fixed tickets #...

I noticed analysing with blackfire that set_error_handler is called multiple times.

By moving it from sniffDecorator to Runner, we gain 61% of memory usage.

See the blackfire compare profile

@50bhan, as you added it in #358, could you please check if everything is okay for you with that change ? 🙏

Verified

This commit was created on GitHub.com and signed with GitHub’s verified signature. The key has expired.
…ltiple times
@50bhan
Copy link
Contributor

50bhan commented May 9, 2020

@Jibbarth Sure, I will check it out tomorrow at let you know.

@50bhan
Copy link
Contributor

50bhan commented May 10, 2020

@Jibbarth I just checked and everything seems OK! Nice work ❤️

@Jibbarth
Copy link
Collaborator Author

@50bhan Thanks for checking it out 💪

@Jibbarth Jibbarth merged commit 88a0737 into nunomaduro:master May 10, 2020
@Jibbarth Jibbarth deleted the improve/add-less-error-handler branch May 10, 2020 06:19
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants