Add support for Laravel 7

[bastien-phi]

Q	A
Bug fix?	no
New feature?	no
Fixed tickets	#368

This PR add support for Laravel 7.

phploc/phploc was updated to ^5.0|^6.0 as only version 6.0 supports symfony/console 5

I had to downgrade minimum stablility to RC because composer/composer has no stable version supporting symfony/console 5 but there is a 1.10.0-RC version. See on packagist

[bastien-phi]

@nunomaduro Indeed, it looks like there is some kind of issue just putting illuminate/console: ^7.0

I got :

  Problem 1
    - Conclusion: don't install symfony/console v5.0.5
    - Conclusion: don't install symfony/console v5.0.4
    - Conclusion: don't install symfony/console v5.0.3
    - Conclusion: don't install symfony/console v5.0.2
    - Conclusion: don't install symfony/console v5.0.1
    - Installation request for phpunit/phpunit ^8.0 -> satisfiable by phpunit/phpunit[8.0.0, 8.0.1, 8.0.2, 8.0.3, 8.0.4, 8.0.5, 8.0.6, 8.1.0, 8.1.1, 8.1.2, 8.1.3, 8.1.4, 8.1.5, 8.1.6, 8.2.0, 8.2.1, 8.2.2, 8.2.3, 8.2.4, 8.2.5, 8.3.0, 8.3.1, 8.3.2, 8.3.3, 8.3.4, 8.3.5, 8.4.0, 8.4.1, 8.4.2, 8.4.3, 8.5.0, 8.5.1, 8.5.2].
    - Conclusion: don't install symfony/console v5.0.0
    - Installation request for phploc/phploc ^5.0|^6.0 -> satisfiable by phploc/phploc[5.0.0, 6.0.0, 6.0.1, 6.0.2].
    - illuminate/console v7.0.2 requires symfony/console ^5.0 -> satisfiable by symfony/console[v5.0.0, v5.0.0-RC1, v5.0.1, v5.0.2, v5.0.3, v5.0.4, v5.0.5].
    - illuminate/console v7.0.1 requires symfony/console ^5.0 -> satisfiable by symfony/console[v5.0.0, v5.0.0-RC1, v5.0.1, v5.0.2, v5.0.3, v5.0.4, v5.0.5].
    - illuminate/console v7.0.0 requires symfony/console ^5.0 -> satisfiable by symfony/console[v5.0.0, v5.0.0-RC1, v5.0.1, v5.0.2, v5.0.3, v5.0.4, v5.0.5].
    - Conclusion: don't install symfony/console v5.0.0-RC1
    - Installation request for illuminate/console ^7.0 -> satisfiable by illuminate/console[v7.0.0, v7.0.1, v7.0.2].

I can't understand the which package is causing the issue... Can you read this ?

[nunomaduro]

Check this: https://github.com/nunomaduro/phpinsights/tree/feat/adds-support-laravel-7

[olivernybroe]

Yeah, so phploc v6 requires php7.3, which is required with laravel 7.

So if we are going to test only with Laravel 7, we will have to drop php7.2 support right?

[bastien-phi]

thanks @nunomaduro . I finally found there was some incompatibility between phploc/phploc:6.x and phpunit/phpunit:8.x

[bastien-phi]

@olivernybroe we can restore laravel ^5.8 and ^6.0 in dev-dependancies to keep php7.2 support with these but I don't see a way to have php7.2 and Laravel 7

[bastien-phi]

IMHO it's not bad to drop support of php 7.2 ...

[olivernybroe]

@bastien-phi For maintaining it would be much nicer to just go straight for php7.4 😉

However, I think by dropping 7.2 support, we will exclude a lot of users, which is something we should be pretty careful with.

I think I'll let @nunomaduro make this decision 👍

[nunomaduro]

Let's #MoveForward, with the note on the readme.

[bastien-phi]

Which means ? Test only on laravel 7 and drop php 7.2 support or this PR is ok right now ?

[nunomaduro]

Means all of this is good.

[bastien-phi]

Thanks @nunomaduro !

[Jibbarth]

This is here to use composer:1.10.0-rc, right ? which allow symfony/console:5.0 ?

[bastien-phi]

Yes