Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Add exit status code error when detect Security Issues #106

Merged
merged 1 commit into from
May 20, 2019
Merged

Add exit status code error when detect Security Issues #106

merged 1 commit into from
May 20, 2019

Conversation

Jibbarth
Copy link
Collaborator

Q A
Bug fix? no
New feature? yes
Fixed tickets N/A

I think when security issues are detected, we should in every case return an exit error code

@nunomaduro nunomaduro merged commit ad79fa7 into nunomaduro:master May 20, 2019
@nunomaduro
Copy link
Owner

Thanks!

@nunomaduro
Copy link
Owner

@Jibbarth Can you make this optional as like other min options? And also update the docs?

@Jibbarth
Copy link
Collaborator Author

In effect, the travis build fail with composer prefer-lowest flag 😓

What do you want in option ? --disable-security-check ? I think it should be enabled by default, WDYT ?

@nunomaduro
Copy link
Owner

Sounds good: Make it explicit.

@Jibbarth Jibbarth mentioned this pull request May 20, 2019
Merged
@Jibbarth Jibbarth deleted the feature/error-if-security-issue branch May 20, 2019 17:59
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@Jibbarth @nunomaduro