Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

NUnitLite accepts --params option but does not make any use of it. #1829

Closed
CharliePoole opened this issue Oct 10, 2016 · 5 comments
Closed

Comments

@CharliePoole
Copy link
Member

At the time of implementing the --params option for the console, we put the option definition into CommandLineOptions.cs, which was then shared by nunit3-console and nunitlite, but we never implemented the option in TestRunner.cs. The intent was that somebody would implement it, but that never happened.

At this time, the option is recognized without error, but is never passed to the framework by the runner.

We should either implement the option or remove it from nunitlite so that an invalid option error is displayed.

@oznetmaster
Copy link
Contributor

My CF build of nunitlite does recognize it, so I must have ported the code to do so from somewhere, but I do not remember doing so, and do not have it conditioned in any way. So I never realized it was not supposed to be supported in nunitlite :( I certainly believe it should be. Do not see any reason for it not to be.

@KWodarczyk
Copy link

Hi Thanks for the feedback Charlie. Any reason why NUnitLite should not take same set of arguments as Console app ? Is it a lot of work ?

@CharliePoole
Copy link
Member Author

No reason. I was just trying to lay out the options for whomever works on this.

@KWodarczyk
Copy link

Ok so I understand that this will be supported in near future ?

@oznetmaster oznetmaster self-assigned this Oct 11, 2016
@oznetmaster
Copy link
Contributor

I will back-port my CF code to propogate this to nunitlite, and also the tests.

oznetmaster added a commit that referenced this issue Oct 12, 2016
oznetmaster added a commit that referenced this issue Oct 12, 2016
This reverts commit 26ea980.
oznetmaster added a commit that referenced this issue Oct 12, 2016
@ChrisMaddock ChrisMaddock added this to the 3.6 milestone Oct 12, 2016
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

No branches or pull requests

4 participants