-
Notifications
You must be signed in to change notification settings - Fork 34
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Update Test method parameter checks to account for CancellationToken #678
Update Test method parameter checks to account for CancellationToken #678
Conversation
General comment. It seems like all the code (analyzer and tests) only checks the case where the CancelAfterAttribute is placed directly on the test-method, but I guess this attribute could also have been placed on the test fixture? |
src/nunit.analyzers/TestCaseSourceUsage/TestCaseSourceUsesStringAnalyzer.cs
Outdated
Show resolved
Hide resolved
src/nunit.analyzers.tests/TestCaseSourceUsage/TestCaseSourceUsesStringAnalyzerTests.cs
Show resolved
Hide resolved
Yes. The But as NUnit supports it, I added tests and support for looking up the attribute on the class. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
+1LGTM. I'm happy to merge this when you are @manfred-brands. Thanks for the work 👍
Fixes #663