Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Preparing for 1.0 release #7

Merged
merged 4 commits into from
Dec 13, 2015
Merged

Preparing for 1.0 release #7

merged 4 commits into from
Dec 13, 2015

Conversation

rprouse
Copy link
Member

@rprouse rprouse commented Dec 10, 2015

No description provided.

@CharliePoole
Copy link
Member

Looks good to me but I'm working on Linux today so I'll leave it for @OsirisTerje to try out.

@OsirisTerje
Copy link
Member

As discussed per mail:
Add Servicetag

<ItemGroup>
    <Service Include="{82A7F48D-3B50-4B1E-B82E-3ADA8210C358}" />
  </ItemGroup>

Change reference to NUnit to use SolutionDir to find package folder, so as to allow for project to be in a subfolder.

@rprouse
Copy link
Member Author

rprouse commented Dec 12, 2015

I have made the changes based on the code reviews and added this project to AppVeyor. I am also going to protect the master branch.

I will merge and release today if nobody has additional comments.

rprouse added a commit that referenced this pull request Dec 13, 2015
@rprouse
Merge pull request #7 from nunit/release-1.0
b829751 
Preparing for 1.0 release
@rprouse rprouse merged commit b829751 into master Dec 13, 2015
@rprouse rprouse deleted the release-1.0 branch December 13, 2015 15:12
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@rprouse @CharliePoole @OsirisTerje