-
-
Notifications
You must be signed in to change notification settings - Fork 164
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Fixes references outside function (#214) #259
Conversation
@sebp @MatthewFlamm can you see if this fixes #214 for you? |
@MatthewFlamm Can you give me a small code example of your problem? Then I can look into it. |
These days I unfortunately won't have time to try and simplify my case down to a simple example. Here is an example from how I used it though: https://github.com/Merck/rtdpy/blob/master/source/AxialDispersion_cc.rst |
That's okay, the linked files were more than enough. I think that I have fixed your problem to: @larsoner The more underlying problem, seem to be that the DEDUPLICATION_TAG is not necessary placed last in the sibling_section list. I have fixed this with a for-loop but I don´t know if there is a more underlying problem here. |
@hoxbro Great work! This works better than 0.8.0 even. I was getting some duplication of links in 0.8.0, but it was still understandable unlike 0.9+. Current behavior is below which works in my full code too. |
@hoxbro do you see some easy way to add a test? For example, you could add something to |
(the tests for |
Awesome, thanks @hoxbro ! |
Closes #214