Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

DOC: Silence many sphinx warnings #11347

Merged
merged 4 commits into from
Jun 28, 2018
Merged

Conversation

mattip
Copy link
Member

@mattip mattip commented Jun 15, 2018

Fixes #11316, although it would be better to fix numpy/numpydoc#69 in a different way.

The :orphan: tag was made specifically to silence this warning. It would be better to find a way for autosummary to create links to method- and attribute-specific subpages without needing anything in the templates.

Additionally, now that the make html output is cleaner, I fixed a number of small documentation problems

@charris charris changed the title DOC: less sphinx warnings DOC: Silence many sphinx warnings Jun 16, 2018
as a replacement for *Numeric*. It also adds the features introduced
by *Numarray* and can also be used to replace *Numarray*.
NumPy derives from the :doc:`old Numerice <reference/routines.oldnumeric>` code
base and can be used as a replacement for *Numeric*. It also adds the features
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

It is not a drop in replacement at this point, as the compatibility module has been removed.

Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

We should probably put the compatibility module somewhere.

Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

reworded

NumPy derives from the old *Numeric* code base and can be used
as a replacement for *Numeric*. It also adds the features introduced
by *Numarray* and can also be used to replace *Numarray*.
NumPy derives from the :doc:`old Numerice <reference/routines.oldnumeric>` code
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Typo, "Numerice"

Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

fixed

@@ -3543,7 +3543,7 @@ def percentile(a, q, axis=None, out=None,
def quantile(a, q, axis=None, out=None,
overwrite_input=False, interpolation='linear', keepdims=False):
"""
Compute the `q`th quantile of the data along the specified axis.
Compute the qth quantile of the data along the specified axis.
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Alternate form "q-th", which seems pretty popular.

Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

change all qth and qth to q-th

@@ -1,3 +1,5 @@
:orphan:
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

better to just remove this file and the oldnumeric one.

Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

removing

@rgommers
Copy link
Member

+1, seems a small enough hack that it's worth putting that in until the numpydoc issue is resolved.

would be good to have a tracking issue somewhere, so that once numpydoc is fixed we can remove the orphan directives again

@mattip
Copy link
Member Author

mattip commented Jun 24, 2018

numpy/numpydoc#69 refers to the :orphan: solution so hopefully it will remind us once that gets fixed.

@mattip
Copy link
Member Author

mattip commented Jun 27, 2018

Would be nice to merge this, it makes reviewing warnings in subsequent PR DOC changes much more manageable

@rgommers rgommers merged commit 26b2a5c into numpy:master Jun 28, 2018
@rgommers
Copy link
Member

LGTM now, merged. Thanks @mattip

@rgommers rgommers added this to the 1.16.0 release milestone Jun 28, 2018
@mattip mattip deleted the less-sphinx-warnings branch October 9, 2018 17:22
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
4 participants