Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add link and image of NumPy comics to Contribute page #795

Open
wants to merge 11 commits into
base: main
Choose a base branch
from

Conversation

MarsBarLee
Copy link
Contributor

I've added a link and image to the 'How to Contribute to NumPy' comic in the Contribute page.

However, the image is showing up as broken like this:
Screenshot 2024-11-18 at 2 23 50 PM

@Mukulikaa Could you take a look at this?

Copy link

netlify bot commented Nov 18, 2024

Deploy Preview for numpy-org ready!

Name Link
🔨 Latest commit 61f16d3
🔍 Latest deploy log https://app.netlify.com/sites/numpy-org/deploys/674e3ad45ee91d0008f25914
😎 Deploy Preview https://deploy-preview-795--numpy-org.netlify.app
📱 Preview on mobile
Toggle QR Code...

QR Code

Use your smartphone camera to open QR code link.

To edit notification comments on pull requests, go to your Netlify site configuration.

@MarsBarLee
Copy link
Contributor Author

I can also resize the image so it's smaller. The image is 780kB, I can make it smaller. The other image in the images folder is 150kB, so I can make the resized image around the same size.

Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@MarsBarLee To keep things organized, please move the image to the static/images/content_images/ folder.

@InessaPawson
Copy link
Member

I can also resize the image so it's smaller. The image is 780kB, I can make it smaller. The other image in the images folder is 150kB, so I can make the resized image around the same size.

@MarsBarLee A lighter image would be better. We prefer to keep them light to reduce load times.

@MarsBarLee
Copy link
Contributor Author

@InessaPawson Thank you for the suggestions! I worked with Mukulika and we fixed the image so it would display properly and at the right size. I wasn't able to get my local development server to show the image but it shows up on Netlify.

The image size right now is hard-coded with pixels- would it be worthwhile to submit a separate PR with shortcode and flexible image size? I see on the About Us page, the sponsor images uses shortcode with sponsor.html.

I tried this shortcode method on a separate branch on my fork here.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants