-
-
Notifications
You must be signed in to change notification settings - Fork 107
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Add link and image of NumPy comics to Contribute page #795
base: main
Are you sure you want to change the base?
Conversation
✅ Deploy Preview for numpy-org ready!
To edit notification comments on pull requests, go to your Netlify site configuration. |
I can also resize the image so it's smaller. The image is 780kB, I can make it smaller. The other image in the |
images/numpy-comic.png
Outdated
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
@MarsBarLee To keep things organized, please move the image to the static/images/content_images/
folder.
@MarsBarLee A lighter image would be better. We prefer to keep them light to reduce load times. |
Co-authored-by: Inessa Pawson <[email protected]>
@InessaPawson Thank you for the suggestions! I worked with Mukulika and we fixed the image so it would display properly and at the right size. I wasn't able to get my local development server to show the image but it shows up on Netlify. The image size right now is hard-coded with pixels- would it be worthwhile to submit a separate PR with shortcode and flexible image size? I see on the About Us page, the sponsor images uses shortcode with I tried this shortcode method on a separate branch on my fork here. |
I've added a link and image to the 'How to Contribute to NumPy' comic in the Contribute page.
However, the image is showing up as broken like this:
@Mukulikaa Could you take a look at this?