This repository has been archived by the owner on Jun 10, 2020. It is now read-only.
MAINT: upgrade mypy to 0.770 (the latest) #45
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
The most significant benefit is changes to `@overload` around what counts as overlapping signatures that could unlock some functionality; see e.g. - numpy#44 (comment) - numpy#11 (comment)
person142
commented
Mar 26, 2020
| @@ -52,7 +56,12 @@ def test_fail(path, py2_arg): | |||
| lines = fin.readlines() | |||
|
|
|||
| errors = defaultdict(lambda: "") | |||
| for error_line in stdout.split("\n"): | |||
| error_lines = stdout.rstrip("\n").split("\n") | |||
| assert re.match( | |||
There was a problem hiding this comment.
Now mypy always outputs at least one summary line; check that this line is as expected (in case it goes away in a later version) and then drop it.
|
This is a straightforward change, so I will merge it in a day or two unless someone complains. |
|
Might be worth adding a dependabot file at some point to track mypy releases. |
|
LGTM, merged. Thanks @person142 |
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The most significant benefit is changes to
@overloadaround whatcounts as overlapping signatures that could unlock some functionality;
see e.g.
np.ufunc#44 (comment)